Automated Code Analysis

cppcheck analysis of dc-qt_0.2.0.alpha-4.1.dsc

• ./dcpp/Client.h:33 [error] - Class ClientListener which is inherited by class Session does not have a virtual destructor
• ./backend/commandhandlers.cpp:488 [error] - Same iterator is used with both params and keys
• ./dcpp/Util.h:106 [error] - Class Flags which is inherited by class QueueItem does not have a virtual destructor
• ./dcpp/AdcCommand.h:169 [error] - Class CommandHandler<AdcHub> which is inherited by class AdcHub does not have a virtual destructor
• ./dcpp/Util.h:106 [error] - Class Flags which is inherited by class UserConnection does not have a virtual destructor
• ./dcpp/UserConnection.h:36 [error] - Class UserConnectionListener which is inherited by class ConnectionManager does not have a virtual destructor
• ./dcpp/BufferedSocket.h:33 [error] - Class BufferedSocketListener which is inherited by class Client does not have a virtual destructor
• ./dcpp/Util.h:106 [error] - Class Flags which is inherited by class Upload does not have a virtual destructor
• ./dcpp/HashManager.cpp:667 [error] - Mismatching allocation and deallocation: buf
• ./dcpp/Util.h:106 [error] - Class Flags which is inherited by class User does not have a virtual destructor
• ./dcpp/Util.cpp:387 [error] - Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./rpcdriver/rpcdriver.h:222 [possible error] - Memory leak: RpcServerDriver::server
• ./ui/connectdialog.h:46 [possible error] - Memory leak: ConnectDialog::publicHubs
• ./ui/connectdialog.h:47 [possible error] - Memory leak: ConnectDialog::favouriteHubs
• ./ui/main.cpp:52 [possible error] - Memory leak: mw
• ./ui/mainwindow.cpp:78 [possible error] - Memory leak: fileDialog
• ./ui/mainwindow.h:49 [possible error] - Memory leak: MainWindow::shareStatusLbl
• ./ui/searchmanager.cpp:55 [possible error] - Memory leak: layout
• ./ui/searchmanager.h:61 [possible error] - Memory leak: SearchManager::searchTabs
• ./ui/searchwidget.h:29 [possible error] - Memory leak: SearchWidget::contextMenu
• ./ui/settingsdialog.h:54 [possible error] - Memory leak: SettingsDialog::shareItemModel
• ./ui/settingsdialog.h:55 [possible error] - Memory leak: SettingsDialog::contextMenu
• ./ui/userfilemodel.cpp:231 [possible error] - Memory leak: item

---