Automated Code Analysis

cppcheck analysis of freeciv_2.2.0-1.dsc

• ./client/gui-ftwl/gui_text.c:418 [error] - Possible null pointer dereference: punit - otherwise it is redundant to check if punit is null at line 425
• ./client/gui-gtk-2.0/helpdlg.c:1148 [error] - Uninitialized variable: buf
• ./client/gui-sdl/widget_scrollbar.c:1321 [error] - Possible null pointer dereference: pBuf
• ./client/gui-win32/connectdlg.c:204 [error] - Array 'row[3]' index 3 out of bounds
• ./client/gui-win32/connectdlg.c:216 [error] - Array 'row[3]' index 3 out of bounds
• ./client/gui-win32/helpdlg.c:882 [error] - Uninitialized variable: buf
• ./client/gui-win32/mapview.c:315 [error] - Array 'indicator_sprite[3]' index 3 out of bounds
• ./client/gui-win32/mapview.c:319 [error] - Buffer access out-of-bounds
• ./client/gui-xaw/helpdlg.c:1063 [error] - Uninitialized variable: buf
• ./common/map.c:309 [error] - Uninitialized variable: y

---