Automated Code Analysis

cppcheck analysis of openswan_2.6.23+dfsg-1.dsc

• ./contrib/lucent/UDP501encap.c:198 [error] - No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./doc/utils/man_xref.c:62 [error] - Resource leak: in
• ./lib/libbsdpfkey/ipsec_dump_policy.c:165 [error] - Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./lib/libcrypto/liboswcrypto/cryptodev.c:782 [possible error] - Memory leak: fixed_src
• ./lib/libdns/rdata/generic/soa_6.c:141 [error] - Unusual pointer arithmetic
• ./lib/libopenswan/optionsfrom.c:101 [error] - Resource leak: f
• ./lib/libopenswan/oswconf.c:198 [error] - Resource leak: fd
• ./lib/libpluto/readwhackmsg.c:82 [error] - Resource leak: record
• ./linux/net/ipsec/ipsec_radij.c:365 [possible error] - Memory leak: retrt
• ./linux/net/ipsec/ipsec_tunnel.c:1741 [error] - Memory leak: dev_ipsec
• ./programs/pluto/keys.c:485 [error] - Uninitialized variable: pathlen
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'DYNAMICDNS'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'HAS_SUN_LEN'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_LIBNSS'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_STATSD'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_UDPFROMTO'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'IPSECPOLICY'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'IPSEC_PLUTO_PCRC_DEBUG'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'IPV6_USE_MIN_MTU'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'IP_RECVERR;MSG_ERRQUEUE'.
• ./programs/pluto/server.c:1187 [error] - Invalid number of character ({) when these macros are defined: 'KLIPS'.
• ./programs/pluto/whackinit.c:539 [possible error] - Dangerous usage of strncat. Tip: the 3rd parameter means maximum number of characters to append
• ./programs/pluto/whackinit.c:546 [possible error] - Dangerous usage of strncat. Tip: the 3rd parameter means maximum number of characters to append
• ./programs/rsasigkey/rsasigkey.c:524 [possible error] - Resource leak: f
• ./programs/showpolicy/showpolicy.c:166 [possible error] - Array 'pktref[1]' index 1 out of bounds
• ./programs/showpolicy/showpolicy.c:170 [possible error] - Array 'pktref[1]' index 1 out of bounds
• ./programs/showpolicy/showpolicy.c:195 [possible error] - Array 'pktref[1]' index 1 out of bounds
• ./programs/showpolicy/showpolicy.c:197 [possible error] - Array 'pktref[1]' index 1 out of bounds
• ./programs/showpolicy/showpolicy.c:199 [possible error] - Array 'pktref[1]' index 1 out of bounds
• ./testing/attacks/espiv/ipsec_hack.c:233 [error] - Buffer access out-of-bounds: espH.payloaddata
• ./testing/utils/siocprivate/tncfg.c:53 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./testing/utils/siocprivate/tncfg.c:53 [error] - Invalid number of character ({) when these macros are defined: 'NET_21'.
• ./testing/utils/uml_netjig/nethub.c:342 [error] - Uninitialized variable: used

---