Automated Code Analysis

cppcheck analysis of xview_3.2p1.4-25.dsc

• ./clients/cmdtool/cmdtool.c:295 [possible error] - Dangerous usage of strncat. Tip: the 3rd parameter means maximum number of characters to append
• ./clients/cmdtool/cmdtool.c:298 [possible error] - Dangerous usage of strncat. Tip: the 3rd parameter means maximum number of characters to append
• ./clients/olvwm-4.1/menu.c:307 [error] - Resource leak: fd
• ./clients/olvwm-4.1/resources.c:1585 [error] - Invalid number of character ({) when these macros are defined: 'DEBUG;OW_I18N_L3'.
• ./clients/olvwm-4.1/resources.c:1585 [error] - Invalid number of character ({) when these macros are defined: 'OW_I18N_L3;DEBUG'.
• ./clients/olvwm-4.1/slots.c:283 [error] - Uninitialized variable: x
• ./clients/olwm/menu.c:308 [error] - Resource leak: fd
• ./clients/olwm/slots.c:273 [error] - Uninitialized variable: x
• ./clients/props/color.c:141 [error] - Uninitialized variable: hex
• ./clients/props/color.c:141 [error] - Uninitialized variable: h
• ./contrib/examples/color/example3.c:81 [error] - Buffer access out-of-bounds
• ./contrib/examples/menus/menu_dir2.c:182 [error] - Resource leak: dirp
• ./lib/libolgx/ol_color.c:145 [error] - Uninitialized variable: hex
• ./lib/libolgx/ol_color.c:145 [error] - Uninitialized variable: h
• ./lib/libxview/base/xv_error.c:171 [error] - Undefined behaviour: msg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./lib/libxview/canvas/cnvs_input.c:431 [error] - Return of the address of an auto-variable
• ./lib/libxview/canvas/cnvs_input.c:456 [error] - Return of the address of an auto-variable
• ./lib/libxview/notify/ndetpoll.c:63 [error] - Invalid number of character (() when these macros are defined: 'POLL'.
• ./lib/libxview/textsw/es_file.c:633 [possible error] - Memory leak: temp_buf_ptr
• ./lib/libxview/textsw/txt_field.c:175 [error] - Uninitialized variable: do_search
• ./lib/libxview/textsw/txt_line.c:114 [error] - Uninitialized variable: error
• ./lib/libxview/ttysw/tty.c:260 [error] - Resource leak: consfd
• ./lib/libxview/ttysw/tty_init.c:931 [possible error] - Resource leak: tty
• ./lib/libxview/ttysw/tty_main.c:814 [error] - Invalid deallocation
• ./util/cpp/cpp1.c:1088 [error] - Invalid number of character ({) when these macros are defined: 'DOCUMENTATION'.
• ./util/msgfmt/msgfmt.c:572 [error] - Resource leak: xdotcf
• ./util/soelim/soelim.c:116 [possible error] - Resource leak: fp
• ./util/xgettext/xgettext.c:918 [error] - Mismatching allocation and deallocation: commentfp

---