Automated Code Analysis

cppcheck analysis of acedb_4.9.39+dfsg.01-2.dsc

• ./w1/acein.c:231 [error] - Possible null pointer dereference: args
• ./w1/arraysub.c:905 [error] - Null pointer dereference
• ./w1/arraysub.c:906 [error] - Null pointer dereference
• ./w1/helpsubs.c:1459 [error] - Uninitialized variable: leftnode
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: ''.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'ACEDB_NDEBUG'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'ARRAY_CHECK'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'BETTER_BOX_SHIFT'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'ED_G_NEVER_INCLUDE_THIS_CODE'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'IBM'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'MACINTOSH'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'MAX'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'METROWERKS'.
• ./w2/gex.c:1805 [error] - Invalid number of character (() when these macros are defined: 'MFC'.
• ./w2/graphmesglist.c:338 [error] - Uninitialized variable: destroy_cb
• ./w2/graphsub.c:936 [error] - Null pointer dereference
• ./w5/disknew.c:1695 [error] - Resource leak: fil
• ./w7/alignmentdisp.c:238 [error] - Resource leak: pipe
• ./w7/fmapgene.c:775 [error] - Invalid number of character ({) when these macros are defined: 'COMPENSATE_FOR_LENGTH;OLD_EXON_SCORE'.
• ./w7/fmapstatus.c:91 [error] - Uninitialized variable: tcolor
• ./w7/griddisp.c:3068 [error] - Uninitialized variable: obj
• ./w7/mapcontrol.c:1214 [error] - Invalid number of character (() when these macros are defined: 'ED_G_NEVER_INCLUDE_THIS_CODE'.
• ./w8/dnaalign.c:133 [error] - Returning pointer to local array variable
• ./w9/asn.c:1108 [error] - Buffer access out-of-bounds
• ./w9/blxselect.c:124 [error] - Buffer access out-of-bounds: qname
• ./w9/blxselect.c:132 [error] - Resource leak: HSPfile
• ./w9/blxselect.c:119 [error] - Dangerous usage of 'seqfilename' (strncpy doesn't always 0-terminate it)
• ./w9/blxselect.c:122 [error] - Dangerous usage of 'HSPfilename' (strncpy doesn't always 0-terminate it)
• ./w9/blxview.c:4225 [error] - Array 'opts[2]' index 2 out of bounds
• ./w9/dbidx.c:122 [error] - Memory leak: head
• ./w9/diskfix.c:91 [error] - Resource leak: fd
• ./w9/dotter.c:2660 [error] - Resource leak: pipe
• ./w9/dotterMain.c:544 [error] - Resource leak: qfile
• ./w9/dotterMain.c:543 [error] - Resource leak: sfile
• ./w9/hexcode.c:125 [error] - Resource leak: fil
• ./wabi/intron2.c:1363 [error] - Memory leak: pl1
• ./wabi/intron2.c:1363 [error] - Memory leak: pl2
• ./wabi/intron2.c:2358 [error] - Mismatching allocation and deallocation: fseq
• ./wabi/intron2.c:2142 [error] - fflush() called on input stream "stdin" may result in undefined behaviour
• ./wabi/trace.c:5686 [error] - Uninitialized variable: y2
• ./wabi/trace.c:5686 [error] - Uninitialized variable: y1
• ./wace/acediffsorted.c:567 [error] - Resource leak: tmpC
• ./wace/makeUserPasswd.c:73 [error] - Memory leak: hash
• ./wace/pmapace.c:234 [error] - Resource leak: out
• ./wace/pmapace2.c:218 [error] - Resource leak: out
• ./wdce/dceclientlib.c:484 [error] - Memory leak: answer
• ./wgd/gd2gif.c:17 [error] - Buffer overrun possible for long cmd-line args
• ./wgd/gd2gif.c:35 [error] - Deallocating a deallocated pointer: in
• ./wgnbk/gnbk.c:101 [error] - Resource leak: fd
• ./wmd5/digcalc.c:80 [error] - Invalid number of character ({) when these macros are defined: 'ED_G_NEVER_INCLUDE_THIS_CODE'.
• ./wsocket/sclient.c:265 [error] - Possible null pointer dereference: passwd_str
• ./wsocket/sclientlib.c:99 [error] - Possible null pointer dereference: hp
• ./wstaden/filecompress.c:161 [error] - Resource leak: newfp
• ./wstaden/filecompress.c:324 [error] - Resource leak: newfp
• ./wtools/split.c:31 [error] - Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)
• ./wzmap/zmapsplit.c:115 [error] - Possible null pointer dereference: pane - otherwise it is redundant to check if pane is null at line 119

---