Automated Code Analysis

cppcheck analysis of cfengine3_3.1.4+dsfg-1.dsc

• ./src/agent.c:913 [error] - instance of "cfstat" object destroyed immediately
• ./src/agentdiagnostic.c:1751 [error] - snprintf size is out of bounds
• ./src/agentdiagnostic.c:2038 [error] - snprintf size is out of bounds
• ./src/agentdiagnostic.c:2091 [error] - snprintf size is out of bounds
• ./src/agentdiagnostic.c:2314 [error] - Memory leak: buf
• ./src/cfreport.c:2544 [error] - Resource leak: dirh
• ./src/cfreport.c:2473 [error] - Memory leak: array
• ./src/client_code.c:1291 [error] - Dangerous usage of 'ipname' (strncpy doesn't always 0-terminate it)
• ./src/env_context.c:913 [error] - Dangerous usage of 'class' (strncpy doesn't always 0-terminate it)
• ./src/evalfunction.c:4485 [error] - Memory leak: result
• ./src/files_edit.c:60 [error] - Memory leak: ec
• ./src/files_interfaces.c:1517 [error] - instance of "cfstat" object destroyed immediately
• ./src/files_repository.c:109 [error] - instance of "cfstat" object destroyed immediately
• ./src/matching.c:1357 [error] - Dangerous usage of 'refbase' (strncpy doesn't always 0-terminate it)
• ./src/promises.c:877 [error] - Dangerous usage of 'pre_buffer' (strncpy doesn't always 0-terminate it)
• ./src/runagent.c:151 [error] - Memory leak: pp
• ./src/server.c:3029 [error] - instance of "cfstat" object destroyed immediately
• ./src/server.c:3141 [error] - instance of "cfstat" object destroyed immediately
• ./src/server.c:2019 [error] - Dangerous usage of 'lastnode' (strncpy doesn't always 0-terminate it)
• ./src/verify_packages.c:470 [error] - Dangerous usage of 'arch' (strncpy doesn't always 0-terminate it)
• ./src/verify_storage.c:360 [error] - Dangerous usage of 'vbuff' (strncpy doesn't always 0-terminate it)

---