Automated Code Analysis

cppcheck analysis of crossfire-client_1.60.0-1.dsc

• ./common/commands.c:210 [error] - Common realloc mistake: "starting_map_info" nulled but not freed upon failure
• ./common/script.c:929 [error] - Possible null pointer dereference: data
• ./common/script.c:472 [error] - Common realloc mistake: "scripts" nulled but not freed upon failure
• ./common/script_lua.c:303 [error] - Common realloc mistake: "scripts" nulled but not freed upon failure
• ./gtk-v2/src/config.c:187 [error] - Dangerous usage of 'xml_basename' (strncpy doesn't always 0-terminate it)
• ./gtk-v2/src/config.c:1064 [error] - Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it)
• ./gtk-v2/src/config.c:1145 [error] - Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it)
• ./gtk-v2/src/config.c:70 [error] - Resource leak: d
• ./gtk-v2/src/opengl.c:160 [error] - Possible null pointer dereference: vi - otherwise it is redundant to check if vi is null at line 171
• ./gtk-v2/src/opengl.c:164 [error] - Possible null pointer dereference: vi - otherwise it is redundant to check if vi is null at line 171
• ./gtk-v2/src/opengl.c:166 [error] - Possible null pointer dereference: vi - otherwise it is redundant to check if vi is null at line 171
• ./gtk-v2/src/png.c:218 [error] - Memory leak: pixels
• ./gtk-v2/src/png.c:294 [error] - Data is allocated but not initialized: ndata
• ./sound-src/common.c:449 [error] - Resource leak: fp

---