Automated Code Analysis

cppcheck analysis of freeciv_2.2.3-1.dsc

• ./client/gui-gtk-2.0/helpdlg.c:1149 [error] - Uninitialized variable: buf
• ./client/gui-sdl/SDL_gfxPrimitives.c:3324 [error] - Common realloc mistake: "gfxPrimitivesPolyInts" nulled but not freed upon failure
• ./client/gui-win32/connectdlg.c:204 [error] - Array 'row[3]' index 3 out of bounds
• ./client/gui-win32/connectdlg.c:216 [error] - Array 'row[3]' index 3 out of bounds
• ./client/gui-win32/helpdlg.c:882 [error] - Uninitialized variable: buf
• ./client/gui-win32/mapview.c:315 [error] - Array 'indicator_sprite[3]' index 3 out of bounds
• ./client/gui-win32/mapview.c:319 [error] - Buffer access out-of-bounds: indicator_sprite
• ./client/gui-xaw/gui_main.c:635 [error] - Array 'econ_label[10]' index -1 out of bounds
• ./client/gui-xaw/helpdlg.c:1064 [error] - Uninitialized variable: buf
• ./common/base.c:139 [error] - Uninitialized variable: adjc_tile_y
• ./common/improvement.c:608 [error] - Possible null pointer dereference: pcity
• ./common/map.c:337 [error] - Uninitialized variable: y
• ./common/map.c:339 [error] - Uninitialized variable: y
• ./common/map.c:608 [error] - Uninitialized variable: adjc_tile_y
• ./common/map.c:634 [error] - Uninitialized variable: tile1_y
• ./common/map.c:1204 [error] - Uninitialized variable: test_tile_y
• ./common/movement.c:265 [error] - Uninitialized variable: ptile2_y
• ./common/terrain.c:480 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:498 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:520 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:688 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:706 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:725 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:745 [error] - Uninitialized variable: adjc_tile_y
• ./common/terrain.c:877 [error] - Uninitialized variable: adjc_tile_y
• ./utility/ftwl/be_common_cairo_32.c:414 [error] - Uninitialized variable: tmp

---