Automated Code Analysis

cppcheck analysis of freecraft_1.19-3.dsc

• ./src/clone/scm.c:801 [error] - Common realloc mistake: "chkdata" nulled but not freed upon failure
• ./src/clone/scm.c:804 [error] - Common realloc mistake: "chkdata" nulled but not freed upon failure
• ./src/clone/scm.c:1663 [error] - Common realloc mistake: "chkdata" nulled but not freed upon failure
• ./src/clone/scm.c:1666 [error] - Common realloc mistake: "chkdata" nulled but not freed upon failure
• ./src/game/campaign.c:332 [error] - Common realloc mistake: "Campaigns" nulled but not freed upon failure
• ./src/game/intro.c:428 [error] - Common realloc mistake: "text" nulled but not freed upon failure
• ./src/game/intro.c:432 [error] - Common realloc mistake: "text" nulled but not freed upon failure
• ./src/libmodplug/load_dsm.c:123 [error] - Buffer access out-of-bounds: psong.orders
• ./src/map/minimap.c:448 [error] - Common realloc mistake: "OldMinimapCursorImage" nulled but not freed upon failure
• ./src/network/commands.c:120 [error] - Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/network/network.c:573 [error] - Memory leak: ncq
• ./src/sound/ccl_sound.c:174 [error] - Invalid deallocation
• ./src/sound/flac.c:186 [error] - Possible null pointer dereference: sample - otherwise it is redundant to check if sample is null at line 187
• ./src/sound/flac.c:185 [error] - Common realloc mistake: "sample" nulled but not freed upon failure
• ./src/sound/mad.c:149 [error] - Possible null pointer dereference: sample - otherwise it is redundant to check if sample is null at line 150
• ./src/sound/mad.c:148 [error] - Common realloc mistake: "sample" nulled but not freed upon failure
• ./src/sound/music.c:192 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./src/sound/music.c:195 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./src/sound/wav.c:202 [error] - Possible null pointer dereference: sample - otherwise it is redundant to check if sample is null at line 203
• ./src/sound/wav.c:202 [error] - Common realloc mistake: "sample" nulled but not freed upon failure
• ./src/ui/icons.c:147 [error] - Common realloc mistake: "Icons" nulled but not freed upon failure
• ./src/ui/icons.c:591 [error] - Common realloc mistake: "IconAliases" nulled but not freed upon failure
• ./src/ui/menus.c:2679 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:3993 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:4030 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:4076 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:4118 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:5024 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:5438 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:5477 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:5707 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:5746 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:6322 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:6925 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:6945 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:6987 [error] - Buffer access out-of-bounds: ScenSelectPath
• ./src/ui/menus.c:3999 [error] - Buffer access out-of-bounds: ScenSelectDisplayPath
• ./src/ui/menus.c:5444 [error] - Buffer access out-of-bounds: ScenSelectDisplayPath
• ./src/ui/menus.c:5713 [error] - Buffer access out-of-bounds: ScenSelectDisplayPath
• ./src/ui/menus.c:6328 [error] - Buffer access out-of-bounds: ScenSelectDisplayPath
• ./src/ui/menus.c:6931 [error] - Buffer access out-of-bounds: ScenSelectDisplayPath
• ./src/ui/menus.c:6341 [error] - Buffer access out-of-bounds: ScenSelectFileName
• ./src/ui/menus.c:7070 [error] - Buffer access out-of-bounds: MenuMapFullPath
• ./src/ui/menus.c:7072 [error] - Buffer access out-of-bounds: MenuMapFullPath
• ./src/video/cursor.c:656 [error] - Common realloc mistake: "OldCursorImage" nulled but not freed upon failure
• ./src/video/png.c:186 [error] - Memory leak: palette
• ./src/video/sweepline.c:269 [error] - Uninitialized variable: r

---