Automated Code Analysis

cppcheck analysis of freeradius_2.1.8+dfsg-1.dsc

• ./src/lib/dhcp.c:1000 [error] - Possible null pointer dereference: original - otherwise it is redundant to check if original is null at line 1003
• ./src/lib/dhcp.c:1000 [error] - Possible null pointer dereference: original
• ./src/lib/snprintf.c:78 [error] - Uninitialized variable: P
• ./src/main/conffile.c:1712 [error] - Resource leak: fp
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_PTHREAD_H'.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_PTHREAD_H;__MINGW32__'.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_SYS_WAIT_H'.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'WITH_COA'.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'WITH_DETAIL'.
• ./src/main/event.c:1824 [error] - Invalid number of character ({) when these macros are defined: 'WTH_COA'.
• ./src/main/realms.c:686 [error] - Possible null pointer dereference: pool - otherwise it is redundant to check if pool is null at line 688
• ./src/modules/rlm_dbm/rlm_dbm_parser.c:370 [error] - Resource leak: fp
• ./src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c:1057 [error] - Uninitialized variable: buffer
• ./src/modules/rlm_ldap/edir_ldapext.c:576 [error] - Memory leak: challenge
• ./src/modules/rlm_mschap/smbencrypt.c:84 [error] - Uninitialized variable: password
• ./src/modules/rlm_opendirectory/rlm_opendirectory.c:264 [error] - Memory leak: pUserName
• ./src/modules/rlm_radutmp/rlm_radutmp.c:597 [error] - Resource leak: fd
• ./src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c:774 [error] - Array 'nasipstr[16]' index 16 out of bounds

---