Automated Code Analysis

cppcheck analysis of grub2_1.99~rc1-4.dsc

• ./debian/grub-extras/ntldr-img/grubinst.c:348 [error] - Buffer access out-of-bounds
• ./grub-core/fs/udf.c:805 [error] - Possible null pointer dereference: utf16 - otherwise it is redundant to check if utf16 is null at line 806
• ./grub-core/fs/udf.c:815 [error] - Possible null pointer dereference: utf16 - otherwise it is redundant to check if utf16 is null at line 816
• ./grub-core/gnulib/regcomp.c:2797 [error] - Uninitialized variable: symb_table
• ./grub-core/gnulib/regexec.c:3908 [error] - Uninitialized variable: extra
• ./grub-core/kern/emu/hostdisk.c:1648 [error] - Resource leak: fd
• ./grub-core/kern/emu/mm.c:86 [error] - Uninitialized variable: p
• ./grub-core/lib/reed_solomon.c:525 [error] - Resource leak: in
• ./grub-core/lib/reed_solomon.c:284 [error] - Memory leak: sigma
• ./grub-core/lib/reed_solomon.c:284 [error] - Memory leak: errpot
• ./grub-core/lib/reed_solomon.c:284 [error] - Memory leak: errpos
• ./grub-core/lib/reed_solomon.c:284 [error] - Memory leak: sy
• ./grub-core/lib/reed_solomon.c:284 [error] - Memory leak: eq
• ./grub-core/loader/i386/bsd.c:932 [error] - Possible null pointer dereference: mods - otherwise it is redundant to check if mods is null at line 933
• ./grub-core/normal/charset.c:872 [error] - Possible null pointer dereference: levels - otherwise it is redundant to check if levels is null at line 873
• ./grub-core/normal/term.c:249 [error] - Possible null pointer dereference: ret - otherwise it is redundant to check if ret is null at line 250
• ./util/grub-mkpasswd-pbkdf2.c:273 [error] - Deallocating a deallocated pointer: f
• ./util/grub-setup.c:463 [error] - Common realloc mistake: "core_img" nulled but not freed upon failure
• ./util/ieee1275/ofpath.c:300 [error] - Resource leak: fd
• ./util/ieee1275/ofpath.c:376 [error] - Memory leak: name_buf
• ./util/ieee1275/ofpath.c:423 [error] - Memory leak: of_path
• ./util/raid.c:90 [error] - Resource leak: fd

---