Automated Code Analysis

cppcheck analysis of hydrogen_0.9.5-1.dsc

• ./gui/src/AudioFileBrowser/AudioFileBrowser.cpp:353 [style] - The iterator incrementing is suspicious - it is incremented at line 353 and then at line 336 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./gui/src/SampleEditor/SampleEditor.cpp:736 [error] - Memory leak: normalframes
• ./gui/src/SampleEditor/SampleEditor.cpp:177 [error] - Possible null pointer dereference: pInstrument
• ./gui/src/SampleEditor/SampleEditor.cpp:183 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:184 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:185 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:186 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:187 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:188 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:189 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:190 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:191 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:192 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:193 [error] - Possible null pointer dereference: pSample
• ./gui/src/SampleEditor/SampleEditor.cpp:411 [error] - Possible null pointer dereference: pInstrument
• ./libs/hydrogen/src/IO/alsa_midi_driver.cpp:119 [error] - Unusual pointer arithmetic
• ./libs/hydrogen/src/IO/alsa_midi_driver.cpp:120 [error] - Unusual pointer arithmetic
• ./libs/hydrogen/src/hydrogen.cpp:1364 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./libs/hydrogen/src/local_file_mgr.cpp:337 [error] - Resource leak: inputFile
• ./libs/hydrogen/src/sample.cpp:521 [error] - Memory leak: origdata_l
• ./libs/hydrogen/src/sample.cpp:521 [error] - Memory leak: origdata_r
• ./libs/hydrogen/src/sound_library.cpp:204 [error] - Resource leak: pGunzippedFile

---