Automated Code Analysis

cppcheck analysis of krb5_1.8.3+dfsg-6.dsc

• ./src/appl/gss-sample/gss-client.c:293 [error] - Resource leak: fd
• ./src/appl/user_user/client.c:100 [error] - Memory leak: hname
• ./src/appl/user_user/client.c:138 [error] - Memory leak: hname
• ./src/ccapi/server/ccs_lock_state.c:336 [error] - Possible null pointer dereference: io_lock_state
• ./src/ccapi/server/ccs_lock_state.c:339 [error] - Possible null pointer dereference: io_lock_state
• ./src/ccapi/server/ccs_lock_state.c:340 [error] - Possible null pointer dereference: io_lock_state
• ./src/ccapi/server/win/ccs_win_pipe.c:62 [error] - Possible null pointer dereference: out_pipe
• ./src/ccapi/server/win/ccs_win_pipe.c:63 [error] - Possible null pointer dereference: out_pipe
• ./src/ccapi/test/test_ccapi_util.c:101 [error] - Memory leak: cred_union
• ./src/ccapi/test/test_ccapi_v2.c:134 [error] - Memory leak: creds_union
• ./src/clients/kpasswd/ksetpwd.c:189 [error] - Memory leak: pPass
• ./src/clients/ksu/ccache.c:420 [error] - Memory leak: linebuf
• ./src/kadmin/cli/kadmin.c:278 [error] - Common realloc mistake: "db_args" nulled but not freed upon failure
• ./src/kadmin/cli/kadmin.c:318 [error] - Common realloc mistake: "db_args" nulled but not freed upon failure
• ./src/kadmin/cli/kadmin.c:692 [error] - Common realloc mistake: "db_args" nulled but not freed upon failure
• ./src/kadmin/dbutil/dump.c:383 [error] - Resource leak: fd
• ./src/kadmin/server/ipropd_svc.c:214 [error] - Deallocating a deallocated pointer: client_name
• ./src/kadmin/server/ipropd_svc.c:215 [error] - Deallocating a deallocated pointer: service_name
• ./src/kadmin/server/ipropd_svc.c:426 [error] - Deallocating a deallocated pointer: client_name
• ./src/kadmin/server/ipropd_svc.c:427 [error] - Deallocating a deallocated pointer: service_name
• ./src/kadmin/testing/util/tcl_krb5_hash.c:114 [error] - Memory leak: table
• ./src/kim/lib/kim_ui.c:233 [error] - Possible null pointer dereference: types
• ./src/lib/crypto/builtin/aes/aescrypp.c:347 [error] - Array 'b1[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:347 [error] - Array 'b1[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:347 [error] - Array 'b1[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:347 [error] - Array 'b1[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:342 [error] - Array 'b0[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:342 [error] - Array 'b0[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:342 [error] - Array 'b0[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:342 [error] - Array 'b0[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:479 [error] - Array 'b1[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:479 [error] - Array 'b1[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:479 [error] - Array 'b1[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:479 [error] - Array 'b1[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:474 [error] - Array 'b0[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:474 [error] - Array 'b0[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:474 [error] - Array 'b0[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypp.c:474 [error] - Array 'b0[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:291 [error] - Array 'b1[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:291 [error] - Array 'b1[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:291 [error] - Array 'b1[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:291 [error] - Array 'b1[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:413 [error] - Array 'b1[4]' index 7 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:413 [error] - Array 'b1[4]' index 5 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:413 [error] - Array 'b1[4]' index 4 out of bounds
• ./src/lib/crypto/builtin/aes/aescrypt.c:413 [error] - Array 'b1[4]' index 6 out of bounds
• ./src/lib/crypto/builtin/sha1/shs.c:122 [error] - Buffer access out-of-bounds: eData
• ./src/lib/crypto/krb/yarrow/yarrow.c:465 [error] - Possible null pointer dereference: y - otherwise it is redundant to check if y is null at line 469
• ./src/lib/gssapi/krb5/util_crypt.c:794 [error] - Uninitialized variable: toktype2
• ./src/lib/gssapi/spnego/spnego_mech.c:1271 [error] - Memory leak: sc
• ./src/lib/kadm5/kadm_rpc_xdr.c:354 [error] - Memory leak: tl2
• ./src/lib/kdb/kdb_log.c:576 [error] - Resource leak: ulogfd
• ./src/lib/krb5/asn.1/asn1_k_decode.c:512 [error] - Possible null pointer dereference: array
• ./src/lib/krb5/krb/rd_req_dec.c:412 [error] - Common realloc mistake: "desired_etypes" nulled but not freed upon failure
• ./src/lib/krb5/os/init_os_ctx.c:126 [error] - Possible null pointer dereference: pbuffer
• ./src/lib/krb5/os/init_os_ctx.c:216 [error] - Memory leak: name
• ./src/lib/krb5/rcache/t_replay.c:62 [error] - Memory leak: str
• ./src/lib/krb5/rcache/t_replay.c:84 [error] - Resource leak: fp
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:534 [error] - Common realloc mistake: "title" nulled but not freed upon failure
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:581 [error] - Common realloc mistake: "upper" nulled but not freed upon failure
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:628 [error] - Common realloc mistake: "lower" nulled but not freed upon failure
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:663 [error] - Common realloc mistake: "ccl" nulled but not freed upon failure
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:744 [error] - Common realloc mistake: "nums" nulled but not freed upon failure
• ./src/lib/krb5/unicode/ucdata/ucgendat.c:782 [error] - Common realloc mistake: "ncodes" nulled but not freed upon failure
• ./src/lib/rpc/getrpcent.c:100 [error] - Memory leak: d
• ./src/lib/rpc/svc_auth_gss.c:435 [error] - Memory leak: auth
• ./src/plugins/kdb/db2/kdb_db2.c:1336 [error] - Deallocating a deallocated pointer: dbname
• ./src/plugins/kdb/db2/kdb_db2.c:1472 [error] - Deallocating a deallocated pointer: db_name
• ./src/plugins/kdb/db2/kdb_db2.c:1719 [error] - Deallocating a deallocated pointer: db_name
• ./src/plugins/kdb/db2/libdb2/test/hash2.tests/passtest.c:40 [error] - Memory leak: key_line
• ./src/plugins/kdb/db2/libdb2/test/hash2.tests/passtest.c:73 [error] - Memory leak: get_key
• ./src/plugins/kdb/ldap/ldap_util/kdb5_ldap_services.c:202 [error] - Memory leak: temp_node
• ./src/plugins/kdb/ldap/ldap_util/kdb5_ldap_services.c:1151 [error] - Resource leak: tmpfd
• ./src/plugins/kdb/ldap/libkdb_ldap/kdb_ldap.c:493 [error] - Memory leak: opt
• ./src/plugins/kdb/ldap/libkdb_ldap/ldap_principal2.c:1282 [error] - Memory leak: filter
• ./src/plugins/kdb/ldap/libkdb_ldap/ldap_principal2.c:1405 [error] - Memory leak: strtime
• ./src/slave/kprop.c:157 [error] - Null pointer dereference
• ./src/slave/kprop.c:169 [error] - Null pointer dereference
• ./src/slave/kprop.c:178 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1045 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1054 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1063 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1072 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1081 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1096 [error] - Null pointer dereference
• ./src/slave/kpropd.c:1125 [error] - Null pointer dereference
• ./src/tests/asn.1/trval.c:151 [error] - Common realloc mistake: "p" nulled but not freed upon failure
• ./src/tests/gss-threads/gss-client.c:331 [error] - Resource leak: fd
• ./src/tests/threads/t_rcache.c:75 [error] - Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/util/ss/invocation.c:62 [error] - Memory leak: new_table
• ./src/util/support/errors.c:115 [error] - Memory leak: str
• ./src/util/support/fake-addrinfo.c:559 [error] - Memory leak: n
• ./src/util/support/fake-addrinfo.c:1026 [error] - Uninitialized variable: serr
• ./src/windows/gss/gss-client.c:274 [error] - Resource leak: fd
• ./src/windows/installer/wix/custom/custom.cpp:512 [error] - Mismatching allocation and deallocation: kpList
• ./src/windows/wintel/auth.c:296 [error] - Uninitialized variable: n
• ./src/windows/wintel/screen.c:529 [error] - Memory leak: pNewLine

---