Automated Code Analysis

cppcheck analysis of ksh_93t+20100621-1.dsc

• ./src/cmd/INIT/proto.c:1775 [error] - syntax error
• ./src/cmd/INIT/ratz.c:3736 [error] - Memory leak: s.path
• ./src/cmd/INIT/ratz.c:4927 [error] - Null pointer dereference
• ./src/cmd/ksh93/edit/emacs.c:730 [error] - Dangerous usage of 'string' (strncpy doesn't always 0-terminate it)
• ./src/cmd/ksh93/sh/name.c:132 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./src/cmd/ksh93/sh/nvtype.c:621 [error] - Possible null pointer dereference: np
• ./src/cmd/ksh93/sh/nvtype.c:1341 [error] - Memory leak: val
• ./src/cmd/ksh93/sh/path.c:952 [error] - Resource leak: fd
• ./src/cmd/ksh93/sh/suid_exec.c:397 [error] - Resource leak: n
• ./src/cmd/ksh93/sh/xec.c:698 [error] - Memory leak: sp
• ./src/cmd/ksh93/sh/xec.c:3012 [error] - Array 'arglist[2]' index 2 out of bounds
• ./src/lib/libast/comp/omitted.c:155 [error] - Array 'buf[2]' index 60 out of bounds
• ./src/lib/libast/comp/omitted.c:155 [error] - Array 'buf[2]' index 61 out of bounds
• ./src/lib/libast/comp/omitted.c:918 [error] - Uninitialized variable: oerrno
• ./src/lib/libast/comp/omitted.c:230 [error] - Uninitialized variable: oerrno
• ./src/lib/libast/comp/wordexp.c:115 [error] - Unusual pointer arithmetic
• ./src/lib/libast/disc/sfdcmore.c:368 [error] - Memory leak: more
• ./src/lib/libast/disc/sfdcprefix.c:152 [error] - Memory leak: pfx
• ./src/lib/libast/port/astconf.c:691 [error] - Invalid number of character (() when these macros are defined: 'ATT_UNIV;UNIV_MAX'.
• ./src/lib/libast/port/astconf.c:691 [error] - Invalid number of character (() when these macros are defined: 'UNIV_MAX'.
• ./src/lib/libast/port/lcgen.c:308 [error] - Resource leak: hf
• ./src/lib/libast/sfio/_sfopen.c:97 [error] - Resource leak: fd
• ./src/lib/libast/stdio/vfwprintf.c:64 [error] - Memory leak: m
• ./src/lib/libast/uwin/crypt.c:855 [error] - Returning pointer to local array variable
• ./src/lib/libast/vmalloc/vmdebug.c:391 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmdebug.c:391 [error] - Uninitialized variable: func
• ./src/lib/libast/vmalloc/vmdebug.c:448 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmdebug.c:448 [error] - Uninitialized variable: func
• ./src/lib/libast/vmalloc/vmdebug.c:713 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmdebug.c:713 [error] - Uninitialized variable: func
• ./src/lib/libast/vmalloc/vmprofile.c:478 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmprofile.c:478 [error] - Uninitialized variable: func
• ./src/lib/libast/vmalloc/vmprofile.c:521 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmprofile.c:521 [error] - Uninitialized variable: func
• ./src/lib/libast/vmalloc/vmprofile.c:706 [error] - Uninitialized variable: line
• ./src/lib/libast/vmalloc/vmprofile.c:706 [error] - Uninitialized variable: func
• ./src/lib/libcmd/tty.c:94 [error] - Invalid number of character (() when these macros are defined: '_mac_STWLINE'.

---