Automated Code Analysis

cppcheck analysis of mt-daapd_0.9~r1696.dfsg-16.dsc

• ./src/conf.c:874 [error] - Common realloc mistake: "prev_comments" nulled but not freed upon failure
• ./src/conf.c:635 [error] - Memory leak: prev_comments
• ./src/configfile.c:876 [error] - Memory leak: page
• ./src/configfile.c:876 [error] - Memory leak: true
• ./src/configfile.c:876 [error] - Memory leak: false
• ./src/db-sql-sqlite3.c:271 [error] - Null pointer dereference
• ./src/db-sql-sqlite3.c:315 [error] - Null pointer dereference
• ./src/db-sql-sqlite3.c:371 [error] - Null pointer dereference
• ./src/db-sql.c:1104 [error] - Memory leak: pinfo
• ./src/io.c:1232 [error] - Possible null pointer dereference: phandle - otherwise it is redundant to check if phandle is null at line 1234
• ./src/os-win32.c:469 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./src/restart.c:91 [error] - Resource leak: retval
• ./src/xml-rpc.c:156 [error] - Common realloc mistake: "badparms" nulled but not freed upon failure

---