Automated Code Analysis

cppcheck analysis of mupen64plus_1.5+dfsg1-13.dsc

• ./glide64/Ini.cpp:69 [error] - Dangerous usage of 'path' (strncpy doesn't always 0-terminate it)
• ./glide64/wrapper/combiner.cpp:578 [error] - Common realloc mistake: "shader_programs" nulled but not freed upon failure
• ./glide64/wrapper/textures.cpp:74 [error] - Common realloc mistake: "t" nulled but not freed upon failure
• ./glide64/wrapper/textures.cpp:87 [error] - Common realloc mistake: "t" nulled but not freed upon failure
• ./jttl_audio/main.c:413 [error] - Undefined behaviour: tMsg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./jttl_audio/main.c:417 [error] - Undefined behaviour: tMsg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./jttl_audio/main.c:421 [error] - Undefined behaviour: tMsg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./jttl_audio/main.c:425 [error] - Undefined behaviour: tMsg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./jttl_audio/main.c:429 [error] - Undefined behaviour: tMsg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./jttl_audio/main.c:765 [error] - Uninitialized variable: path
• ./jttl_audio/main.c:839 [error] - Uninitialized variable: path
• ./jttl_audio/volume.c:85 [error] - Uninitialized variable: ret
• ./main/gui_gtk/debugger/ui_disasm_list.c:533 [error] - Possible null pointer dereference: iter - otherwise it is redundant to check if iter is null at line 538
• ./main/gui_gtk/debugger/varlist.c:348 [error] - Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: iter
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: country
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: md5hash
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: crc1
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: crc2
• ./main/gui_gtk/rombrowser.c:285 [error] - Memory leak: savetype
• ./main/gui_gtk/rombrowser.c:285 [error] - Memory leak: players
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: size
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: compressiontype
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: imagetype
• ./main/gui_gtk/rombrowser.c:297 [error] - Memory leak: cicchip
• ./main/gui_gtk/rombrowser.c:285 [error] - Memory leak: rumble
• ./main/rom.c:168 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/rom.c:178 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/rom.c:241 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/rom.c:253 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/rom.c:279 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/rom.c:289 [error] - Common realloc mistake: "localrom" nulled but not freed upon failure
• ./main/zip/unzip.c:532 [error] - Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 533
• ./main/zip/unzip.c:1110 [error] - Possible null pointer dereference: pfile_in_zip_read_info - otherwise it is redundant to check if pfile_in_zip_read_info is null at line 1112
• ./r4300/x86/assemble.c:68 [error] - Common realloc mistake: "jumps_table" nulled but not freed upon failure
• ./rice_video/RDP_Texture.h:2174 [error] - Array 'tmenEntryBuffer[20]' index 20 out of bounds
• ./rice_video/liblinux/pngmem.c:437 [error] - Invalid number of character (() when these macros are defined: 'MAXSEG_64K'.
• ./rice_video/liblinux/pngmem.c:437 [error] - Invalid number of character (() when these macros are defined: 'MAXSEG_64K;_MSC_VER'.
• ./rice_video/liblinux/pngmem.c:437 [error] - Invalid number of character (() when these macros are defined: 'MSDOS'.
• ./tools/r4300prof.c:307 [error] - Memory leak: pOpAddrTable

---