Automated Code Analysis

cppcheck analysis of pcp_3.4.0.dsc

• ./src/cpan/PMDA/local.c:65 [error] - Common realloc mistake: "timers" nulled but not freed upon failure
• ./src/cpan/PMDA/local.c:101 [error] - Common realloc mistake: "files" nulled but not freed upon failure
• ./src/libpcp/src/access.c:238 [error] - Common realloc mistake: "hostList" nulled but not freed upon failure
• ./src/libpcp/src/connectlocal.c:359 [error] - Common realloc mistake: "dsotab" nulled but not freed upon failure
• ./src/libpcp/src/fetchlocal.c:67 [error] - Common realloc mistake: "splitlist" nulled but not freed upon failure
• ./src/libpcp/src/fetchlocal.c:70 [error] - Memory leak: ans
• ./src/libpcp/src/ipc.c:68 [error] - Common realloc mistake: "__pmIPCTablePtr" nulled but not freed upon failure
• ./src/libpcp/src/logmeta.c:456 [error] - Memory leak: dp
• ./src/libpcp/src/logmeta.c:456 [error] - Memory leak: tbuf
• ./src/libpcp/src/logutil.c:210 [error] - Common realloc mistake: "logfilename" nulled but not freed upon failure
• ./src/libpcp/src/loop.c:209 [error] - Common realloc mistake: "pfd" nulled but not freed upon failure
• ./src/libpcp/src/loop.c:296 [error] - Memory leak: ss
• ./src/libpcp/src/p_result.c:319 [error] - Invalid number of character (() when these macros are defined: 'DESPERATE;HAVE_64BIT_PTR'.
• ./src/libpcp/src/pmns.c:828 [error] - Memory leak: t
• ./src/libpcp/src/util.c:1091 [error] - Resource leak: dirp
• ./src/libpcp/src/win32.c:303 [error] - Common realloc mistake: "cmdline" nulled but not freed upon failure
• ./src/libpcp_gui/src/timeclient.c:176 [error] - Common realloc mistake: "k" nulled but not freed upon failure
• ./src/libpcp_gui/src/timestate.c:152 [error] - Possible null pointer dereference: pmtime - otherwise it is redundant to check if pmtime is null at line 153
• ./src/libpcp_gui/src/timestate.c:152 [error] - Common realloc mistake: "pmtime" nulled but not freed upon failure
• ./src/libpcp_gui/src/timestate.c:165 [error] - Common realloc mistake: "pmtime" nulled but not freed upon failure
• ./src/libpcp_import/src/import.c:161 [error] - Common realloc mistake: "context_tab" nulled but not freed upon failure
• ./src/libpcp_pmda/src/callback.c:508 [error] - Common realloc mistake: "vset" nulled but not freed upon failure
• ./src/libpcp_pmda/src/help.c:59 [error] - Common realloc mistake: "tab" nulled but not freed upon failure
• ./src/libpcp_trace/src/hash.c:139 [error] - Memory leak: hash
• ./src/libpcp_trace/src/pdu.c:79 [error] - Common realloc mistake: "more" nulled but not freed upon failure
• ./src/newhelp/newhelp.c:150 [error] - Common realloc mistake: "hindex" nulled but not freed upon failure
• ./src/pmcd/src/client.c:96 [error] - Common realloc mistake: "client" nulled but not freed upon failure
• ./src/pmcd/src/config.c:2339 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./src/pmcd/src/config.c:2339 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_DLFCN_H'.
• ./src/pmcd/src/config.c:2339 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_DLOPEN'.
• ./src/pmcd/src/config.c:2339 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_DL_H'.
• ./src/pmcd/src/config.c:643 [error] - Memory leak: entryPoint
• ./src/pmcd/src/config.c:1405 [error] - Uninitialized variable: fd
• ./src/pmcd/src/pmcd.c:127 [error] - Common realloc mistake: "reqPorts" nulled but not freed upon failure
• ./src/pmcd/src/pmcd.c:269 [error] - Common realloc mistake: "portlist" nulled but not freed upon failure
• ./src/pmcd/src/pmcd.c:992 [error] - Common realloc mistake: "portlist" nulled but not freed upon failure
• ./src/pmcd/src/pmcd.c:1033 [error] - Common realloc mistake: "portlist" nulled but not freed upon failure
• ./src/pmcd/src/pmcd.c:1169 [error] - Common realloc mistake: "badHost" nulled but not freed upon failure
• ./src/pmdas/aix/aix.c:68 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./src/pmdas/hotproc/src/config.c:133 [error] - Memory leak: ptr
• ./src/pmdas/linux/cgroups.c:307 [error] - Memory leak: atoms
• ./src/pmdas/linux/dynamic.c:45 [error] - Common realloc mistake: "dynamic" nulled but not freed upon failure
• ./src/pmdas/linux/ksym.c:206 [error] - Common realloc mistake: "ksym_a" nulled but not freed upon failure
• ./src/pmdas/linux/ksym.c:318 [error] - Common realloc mistake: "ksym_a" nulled but not freed upon failure
• ./src/pmdas/linux/ksym.c:448 [error] - Common realloc mistake: "ksym_a" nulled but not freed upon failure
• ./src/pmdas/linux/ksym.c:515 [error] - Common realloc mistake: "ksym_a" nulled but not freed upon failure
• ./src/pmdas/linux/ksym.c:534 [error] - Resource leak: fp
• ./src/pmdas/linux/proc_interrupts.c:68 [error] - Resource leak: fp
• ./src/pmdas/linux/proc_net_tcp.c:53 [error] - Resource leak: fp
• ./src/pmdas/linux/proc_pid.c:672 [error] - Common realloc mistake: "retbuf" nulled but not freed upon failure
• ./src/pmdas/linux/proc_slabinfo.c:62 [error] - Resource leak: fp
• ./src/pmdas/linux/proc_stat.c:50 [error] - Common realloc mistake: "statbuf" nulled but not freed upon failure
• ./src/pmdas/linux/proc_uptime.c:50 [error] - Resource leak: fd
• ./src/pmdas/mailq/mailq.c:279 [error] - Common realloc mistake: "histo" nulled but not freed upon failure
• ./src/pmdas/mailq/mailq.c:332 [error] - Common realloc mistake: "histo" nulled but not freed upon failure
• ./src/pmdas/mmv/mmv.c:149 [error] - Common realloc mistake: "slist" nulled but not freed upon failure
• ./src/pmdas/mounts/mounts.c:228 [error] - Common realloc mistake: "mount_list" nulled but not freed upon failure
• ./src/pmdas/pmcd/src/pmcd.c:394 [error] - Common realloc mistake: "pmies" nulled but not freed upon failure
• ./src/pmdas/pmcd/src/pmcd.c:1596 [error] - Common realloc mistake: "whoamis" nulled but not freed upon failure
• ./src/pmdas/process/process.c:206 [error] - Common realloc mistake: "num_procs" nulled but not freed upon failure
• ./src/pmdas/process/process.c:306 [error] - Common realloc mistake: "pidlist" nulled but not freed upon failure
• ./src/pmdas/roomtemp/roomtemp.c:141 [error] - Common realloc mistake: "sntab" nulled but not freed upon failure
• ./src/pmdas/sample/src/sample.c:631 [error] - Common realloc mistake: "_dyn_ctr" nulled but not freed upon failure
• ./src/pmdas/sample/src/sample.c:1658 [error] - Common realloc mistake: "vset" nulled but not freed upon failure
• ./src/pmdas/sendmail/sendmail.c:361 [error] - Resource leak: fp
• ./src/pmdas/shping/pmda.c:195 [error] - Common realloc mistake: "cmdlist" nulled but not freed upon failure
• ./src/pmdas/shping/shping.c:489 [error] - Common realloc mistake: "vset" nulled but not freed upon failure
• ./src/pmdas/solaris/sysinfo.c:59 [error] - Common realloc mistake: "ctl" nulled but not freed upon failure
• ./src/pmdas/summary/summary.c:97 [error] - Common realloc mistake: "meta" nulled but not freed upon failure
• ./src/pmdas/summary/summary.c:137 [error] - Common realloc mistake: "cachedResult" nulled but not freed upon failure
• ./src/pmdas/trace/app2.c:160 [error] - Resource leak: foo
• ./src/pmdas/trace/app3.c:160 [error] - Resource leak: foo
• ./src/pmdas/trace/src/client.c:71 [error] - Common realloc mistake: "clients" nulled but not freed upon failure
• ./src/pmdas/trace/src/trace.c:963 [error] - Common realloc mistake: "vset" nulled but not freed upon failure
• ./src/pmdas/weblog/pmda.c:590 [error] - Common realloc mistake: "wl_regexTable" nulled but not freed upon failure
• ./src/pmdas/weblog/pmda.c:831 [error] - Common realloc mistake: "wl_servers" nulled but not freed upon failure
• ./src/pmdas/weblog/pmda.c:740 [error] - Common realloc mistake: "wl_regexTable" nulled but not freed upon failure
• ./src/pmdas/weblog/weblog.c:2660 [error] - Common realloc mistake: "vset" nulled but not freed upon failure
• ./src/pmdas/windows/instance.c:151 [error] - Memory leak: name
• ./src/pmdas/windows/open.c:562 [error] - Common realloc mistake: "info" nulled but not freed upon failure
• ./src/pmdas/windows/pdhlist.c:67 [error] - fflush() called on input stream "stdin" may result in undefined behaviour
• ./src/pmdumplog/pmdumplog.c:337 [error] - Common realloc mistake: "pmid" nulled but not freed upon failure
• ./src/pmdumplog/pmdumplog.c:534 [error] - Common realloc mistake: "pmid" nulled but not freed upon failure
• ./src/pmie/src/stomp.c:214 [error] - Uninitialized variable: config
• ./src/pmieconf/rules.c:1583 [error] - Common realloc mistake: "list" nulled but not freed upon failure
• ./src/pmieconf/rules.c:1623 [error] - Common realloc mistake: "result" nulled but not freed upon failure
• ./src/pmieconf/rules.c:1947 [error] - Common realloc mistake: "save_area" nulled but not freed upon failure
• ./src/pmieconf/rules.c:871 [error] - Memory leak: r
• ./src/pmieconf/rules.c:1670 [error] - Memory leak: p
• ./src/pmiestatus/pmiestatus.c:67 [error] - Resource leak: f
• ./src/pmlc/util.c:87 [error] - Common realloc mistake: "indom" nulled but not freed upon failure
• ./src/pmlogger/pmlogger.c:413 [error] - Mismatching allocation and deallocation: msgf
• ./src/pmlogger/preamble.c:162 [error] - Memory leak: instid
• ./src/pmlogreduce/dometric.c:16 [error] - Common realloc mistake: "pmidlist" nulled but not freed upon failure
• ./src/pmlogreduce/dometric.c:28 [error] - Common realloc mistake: "metriclist" nulled but not freed upon failure
• ./src/pmlogsummary/pmlogsummary.c:346 [error] - Possible null pointer dereference: avedata - otherwise it is redundant to check if avedata is null at line 347
• ./src/pmns/pmnsmerge.c:102 [error] - Memory leak: tab
• ./src/pmprobe/pmprobe.c:38 [error] - Common realloc mistake: "pmidlist" nulled but not freed upon failure
• ./src/pmproxy/client.c:43 [error] - Common realloc mistake: "client" nulled but not freed upon failure
• ./src/pmproxy/pmproxy.c:83 [error] - Common realloc mistake: "reqPorts" nulled but not freed upon failure
• ./src/pmtop/pmtop.c:1005 [error] - Common realloc mistake: "rate_tab" nulled but not freed upon failure
• ./src/pmtop/pmtop.c:1012 [error] - Common realloc mistake: "val_tab" nulled but not freed upon failure

---