Automated Code Analysis

cppcheck analysis of pinot_0.85-1.dsc

• ./IndexSearch/Xapian/AbstractGenerator.cpp:133 [style] - The iterator incrementing is suspicious - it is incremented at line 133 and then at line 119 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./Tokenize/filters/ExternalFilter.cc:395 [error] - Resource leak: outFd
• ./UI/GTK2/src/PinotSettings.cpp:1514 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./Utils/xdgmime/xdgmime.c:148 [error] - Common realloc mistake: "_caches" nulled but not freed upon failure
• ./Utils/xdgmime/xdgmimemagic.c:188 [error] - Common realloc mistake: "retval" nulled but not freed upon failure
• ./Utils/xdgmime/xdgmimemagic.c:275 [error] - Memory leak: buffer

---