Automated Code Analysis

cppcheck analysis of player_3.0.2+dfsg-2.dsc

• ./libplayercore/devicetable.cc:195 [error] - Memory leak: str_addr_copy
• ./libplayercore/filewatcher.cc:192 [error] - Common realloc mistake: "WatchedFiles" nulled but not freed upon failure
• ./libplayercore/plugins.cc:129 [error] - Dangerous usage of 'installdir' (strncpy doesn't always 0-terminate it)
• ./libplayerinterface/functiontable.c:193 [error] - Common realloc mistake: "ftable" nulled but not freed upon failure
• ./libplayerinterface/interface_util.c:112 [error] - Common realloc mistake: "itable" nulled but not freed upon failure
• ./server/drivers/audio/alsa.cc:1751 [error] - Memory leak: keep
• ./server/drivers/camera/v4l/v4lframe.c:254 [error] - Resource leak: fp
• ./server/drivers/laser/lms400_cola.cc:219 [error] - Memory leak: mac
• ./server/drivers/laser/sicklms400.cc:534 [error] - Mismatching allocation and deallocation: macaddress
• ./server/drivers/laser/sicklms400.cc:510 [error] - Memory leak: macaddress
• ./server/drivers/laser/sicklms400.cc:535 [error] - Mismatching allocation and deallocation: hexaddress
• ./server/drivers/laser/sicklms400.cc:510 [error] - Memory leak: hexaddress
• ./server/drivers/localization/amcl/map/map_store.c:66 [error] - Resource leak: file
• ./server/drivers/localization/amcl/map/map_store.c:160 [error] - Resource leak: file
• ./server/drivers/map/vmapfile.cc:264 [error] - Resource leak: fp
• ./server/drivers/mixed/cmucam2/cmucam2.cc:514 [error] - Deallocating a deallocated pointer: camera_packet
• ./server/drivers/mixed/p2os/p2os.h:215 [error] - Memory leak: circbuf::buf
• ./server/drivers/rfid/skyetekM1.cc:427 [error] - Uninitialized variable: response_buf
• ./server/drivers/wsn/phidgetAcc.cc:280 [error] - Memory leak: p_accel
• ./utils/logsplitter/logsplitter.c:187 [error] - Resource leak: fd
• ./utils/playercam/playercam.c:425 [error] - Common realloc mistake: "g_img" nulled but not freed upon failure
• ./utils/playercam/playercam.c:439 [error] - Common realloc mistake: "g_img" nulled but not freed upon failure
• ./utils/playerv/pv_dev_dio.c:137 [error] - Undefined behaviour: str is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./utils/playerv/pv_dev_dio.c:139 [error] - Undefined behaviour: str is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.

---