Automated Code Analysis

cppcheck analysis of radare2_0.7-3.dsc

• ./binr/rabin2/rabin2.c:141 [error] - Memory leak: path
• ./binr/rarc2/out.c:23 [error] - Common realloc mistake: "output" nulled but not freed upon failure
• ./binr/rasc2/rasc2.c:86 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./libr/anal/arch/x86/x86im/x86im_fmt.c:1087 [error] - Undefined behaviour: src is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./libr/anal/fcn.c:382 [error] - Memory leak: str
• ./libr/asm/arch/java/javasm/javasm.c:286 [error] - Resource leak: fd
• ./libr/asm/arch/mips/gnu/mips-dis.c:1675 [error] - Uninitialized variable: buffer
• ./libr/asm/arch/mips/gnu/mips-dis.c:1896 [error] - Uninitialized variable: buffer
• ./libr/asm/arch/mips/gnu/mips-dis.c:2063 [error] - Uninitialized variable: buffer
• ./libr/asm/arch/ppc/gnu/ppc-dis.c:257 [error] - Uninitialized variable: buffer
• ./libr/asm/arch/sparc/gnu/sparc-dis.c:519 [error] - Uninitialized variable: buffer
• ./libr/asm/asm.c:405 [error] - Memory leak: lbuf
• ./libr/bin/format/elf/elf.c:626 [error] - Common realloc mistake: "ret" nulled but not freed upon failure
• ./libr/bin/format/elf/elf.c:642 [error] - Common realloc mistake: "ret" nulled but not freed upon failure
• ./libr/bin/format/elf/elf.c:738 [error] - Common realloc mistake: "ret" nulled but not freed upon failure
• ./libr/bin/format/elf/elf.c:778 [error] - Common realloc mistake: "ret" nulled but not freed upon failure
• ./libr/bin/format/java/java.c:379 [error] - Common realloc mistake: "strings" nulled but not freed upon failure
• ./libr/bin/format/java/java.c:389 [error] - Common realloc mistake: "strings" nulled but not freed upon failure
• ./libr/bin/format/pe/pe.c:404 [error] - Common realloc mistake: "imports" nulled but not freed upon failure
• ./libr/bin/format/pe/pe.c:314 [error] - Memory leak: exports
• ./libr/bin/format/pe/pe.c:428 [error] - Memory leak: libs
• ./libr/bin/mangling/cxx/cp-demangle.c:3669 [error] - instance of "d_print_mod" object destroyed immediately
• ./libr/bin/mangling/cxx/cp-demangle.c:3882 [error] - instance of "d_print_mod" object destroyed immediately
• ./libr/bin/mangling/cxx/cp-demangle.c:3997 [error] - instance of "d_print_mod" object destroyed immediately
• ./libr/bin/mangling/cxx/cp-demangle.c:4021 [error] - instance of "d_print_mod" object destroyed immediately
• ./libr/bin/mangling/cxx/cp-demangle.c:4466 [error] - instance of "d_print_mod" object destroyed immediately
• ./libr/cmd/macro.c:135 [error] - Memory leak: macro.name
• ./libr/cmd/macro.c:135 [error] - Memory leak: macro.code
• ./libr/cmd/macro.c:135 [error] - Memory leak: macro.args
• ./libr/core/anal.c:22 [error] - Common realloc mistake: "cmdstr" nulled but not freed upon failure
• ./libr/core/core.c:31 [error] - Memory leak: bptr
• ./libr/core/rtr.c:78 [error] - Dangerous usage of 'input' (strncpy doesn't always 0-terminate it)
• ./libr/crypto/p/crypto_aes_algo.c:353 [error] - Resource leak: fd
• ./libr/crypto/p/crypto_aes_algo.c:380 [error] - Resource leak: fd
• ./libr/db/table.c:63 [error] - Uninitialized variable: name
• ./libr/debug/p/drx.c:82 [error] - Array 'regs[7]' index 7 out of bounds
• ./libr/debug/p/drx.c:82 [error] - Array 'regs[7]' index 7 out of bounds
• ./libr/debug/p/native/darwin.c:55 [error] - Resource leak: dh
• ./libr/flags/old_flags.c:784 [error] - Memory leak: flag
• ./libr/fs/p/fs_posix.c:55 [error] - Resource leak: dir
• ./libr/fs/p/grub/main.c:116 [error] - Memory leak: file
• ./libr/io/io.c:113 [error] - Resource leak: fd
• ./libr/io/p/io_gdb.c:29 [error] - Dangerous usage of 'host' (strncpy doesn't always 0-terminate it)
• ./libr/io/p/io_rap.c:29 [error] - Memory leak: tmp
• ./libr/lib/lib.c:154 [error] - Uninitialized variable: ret
• ./libr/reg/arena.c:18 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./libr/reg/value.c:17 [error] - Possible null pointer dereference: item - otherwise it is redundant to check if item is null at line 19
• ./libr/sysproxy/syscall-linux.c:182 [error] - Array 'args[1]' index 1 out of bounds
• ./libr/sysproxy/syscall-linux.c:180 [error] - Array 'arg[1]' index 1 out of bounds
• ./libr/sysproxy/syscall-linux.c:181 [error] - Array 'arg[1]' index 1 out of bounds
• ./libr/th/task.c:21 [error] - The code contains characters that are unhandled. Neither unicode nor extended ascii are supported. (line=21, character code=c2)
• ./libr/th/task.c:21 [error] - The code contains characters that are unhandled. Neither unicode nor extended ascii are supported. (line=21, character code=a0)
• ./libr/util/file.c:100 [error] - Resource leak: fd
• ./libr/util/str.c:503 [error] - Common realloc mistake: "temp" nulled but not freed upon failure
• ./libr/util/str.c:511 [error] - Common realloc mistake: "temp" nulled but not freed upon failure
• ./libr/util/sys.c:46 [error] - Resource leak: dir
• ./libr/util/w32-sys.c:21 [error] - Common realloc mistake: "argv0" nulled but not freed upon failure
• ./libr/util/w32-sys.c:123 [error] - Common realloc mistake: "str" nulled but not freed upon failure
• ./libr/util/w32-sys.c:41 [error] - Memory leak: argv0
• ./libr/vm/reg.c:165 [error] - Possible null pointer dereference: sp - otherwise it is redundant to check if sp is null at line 167
• ./libr/vm/vm.c:127 [error] - Memory leak: r

---