Automated Code Analysis

cppcheck analysis of rosegarden_11.02-1.dsc

• ./src/base/Composition.cpp:1710 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./src/base/XmlExportable.cpp:68 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./src/base/XmlExportable.cpp:92 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./src/base/XmlExportable.cpp:168 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./src/commands/notation/RespellCommand.cpp:191 [error] - Uninitialized variable: pitch
• ./src/commands/notation/RespellCommand.cpp:192 [error] - Uninitialized variable: pitch
• ./src/document/io/LilyPondExporter.cpp:1464 [error] - Uninitialized variable: verse
• ./src/document/io/LilyPondExporter.cpp:1466 [error] - Uninitialized variable: verse
• ./src/gui/dialogs/DialogSuppressor.cpp:66 [error] - Possible null pointer dereference: p - otherwise it is redundant to check if p is null at line 67
• ./src/gui/editors/notation/NotationVLayout.cpp:121 [error] - Uninitialized variable: noteType
• ./src/gui/editors/segment/TrackButtons.cpp:265 [error] - Invalid iterator: mit
• ./src/gui/editors/segment/TrackButtons.cpp:265 [error] - Same iterator is used with both m_muteLeds and m_recordLeds
• ./src/gui/general/LilyPondProcessor.cpp:235 [style] - Redundant assignment of "pdfViewer" in switch
• ./src/gui/studio/DeviceManagerDialog.cpp:646 [error] - Possible null pointer dereference: mdev - otherwise it is redundant to check if mdev is null at line 649
• ./src/sound/MappedStudio.cpp:1473 [style] - The iterator incrementing is suspicious - it is incremented at line 1473 and then at line 1470 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/sound/MappedStudio.cpp:1501 [style] - The iterator incrementing is suspicious - it is incremented at line 1501 and then at line 1498 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/sound/PlayableAudioFile.cpp:172 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./src/sound/RecordableAudioFile.cpp:113 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure

---