Automated Code Analysis

cppcheck analysis of rplay_3.3.2-12.dsc

• ./contrib/jukebox-1.3/jukebox.c:189 [error] - Common realloc mistake: "songs" nulled but not freed upon failure
• ./contrib/jukebox-1.3/jukebox.c:257 [error] - Common realloc mistake: "songs" nulled but not freed upon failure
• ./librplay/rplay.c:567 [error] - Memory leak: rp.buf
• ./rplay/rplay.c:767 [error] - Resource leak: fd
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'AUTH'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'FAKE_VOLUME'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_ADPCM'.
• ./rplayd/spool.c:835 [error] - Dangerous usage of 'name_buf' (strncpy doesn't always 0-terminate it)
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_CONFIG_H'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_CONFIG_H;TEST_FLANGE'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GSM'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GSM;HAVE_GSM_GSM_H'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GSM;HAVE_GSM_GSM_H;_NO_PROTO'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GSM;HAVE_GSM_GSM_H;__STDC__'.
• ./rplayd/spool.c:1180 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GSM;HAVE_GSM_GSM_H;__cplusplus'.
• ./rptp/rptp.c:669 [error] - Resource leak: fp
• ./rx/rxanal.c:430 [error] - Possible null pointer dereference: inx - otherwise it is redundant to check if inx is null at line 432
• ./rx/rxanal.c:530 [error] - Possible null pointer dereference: inx - otherwise it is redundant to check if inx is null at line 532
• ./rx/rxanal.c:635 [error] - Possible null pointer dereference: inx - otherwise it is redundant to check if inx is null at line 637
• ./rx/rxanal.c:113 [error] - Uninitialized variable: this_subexp
• ./rx/rxnfa.c:389 [error] - Memory leak: edge
• ./rx/rxnode.c:123 [error] - Uninitialized variable: tmp
• ./rx/rxnode.c:125 [error] - Uninitialized variable: tmp

---