Automated Code Analysis

cppcheck analysis of samba_3.5.6~dfsg-4.dsc

• ./examples/auth/crackcheck/crackcheck.c:113 [error] - fflush() called on input stream "stdin" may result in undefined behaviour
• ./lib/popt/popt.c:601 [error] - Common realloc mistake: "t" nulled but not freed upon failure
• ./lib/popt/popt.c:612 [error] - Common realloc mistake: "t" nulled but not freed upon failure
• ./lib/replace/test/os2_delete.c:108 [error] - Resource leak: d
• ./lib/replace/test/testsuite.c:82 [error] - Resource leak: fd
• ./lib/replace/test/testsuite.c:166 [error] - Memory leak: x
• ./lib/replace/test/testsuite.c:260 [error] - Memory leak: x
• ./lib/replace/test/testsuite.c:954 [error] - Resource leak: fd
• ./lib/replace/test/testsuite.c:1015 [error] - Resource leak: fd
• ./lib/tdb/tools/tdbtorture.c:305 [error] - Memory leak: pids
• ./lib/util/become_daemon.c:46 [error] - Resource leak: fd
• ./lib/util/talloc_stack.c:160 [error] - Memory leak: ts
• ./lib/util/talloc_stack.c:187 [error] - instance of "talloc_stackframe" object destroyed immediately
• ./lib/zlib/contrib/minizip/unzip.c:522 [error] - Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 523
• ./lib/zlib/contrib/minizip/unzip.c:1091 [error] - Possible null pointer dereference: pfile_in_zip_read_info - otherwise it is redundant to check if pfile_in_zip_read_info is null at line 1093
• ./lib/zlib/examples/gun.c:393 [error] - Uninitialized variable: next
• ./lib/zlib/gzio.c:147 [error] - Memory leak: s.path
• ./nsswitch/nsstest.c:321 [error] - Possible null pointer dereference: pwd - otherwise it is redundant to check if pwd is null at line 322
• ./nsswitch/nsstest.c:350 [error] - Possible null pointer dereference: grp - otherwise it is redundant to check if grp is null at line 351
• ./source3/client/smbspool.c:313 [error] - Resource leak: fp
• ./source3/lib/tldap.c:1881 [error] - Possible null pointer dereference: msg
• ./source3/lib/tldap.c:1882 [error] - Possible null pointer dereference: msg
• ./source3/modules/vfs_preopen.c:233 [error] - instance of "preopen_helper" object destroyed immediately
• ./source3/param/loadparm.c:4748 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_GETRLIMIT;RLIMIT_NOFILE'.
• ./source3/passdb/lookup_sid.c:909 [error] - Possible null pointer dereference: rids
• ./source3/registry/regfio.c:1531 [error] - Possible null pointer dereference: hbin - otherwise it is redundant to check if hbin is null at line 1535
• ./source3/torture/nsstest.c:404 [error] - Possible null pointer dereference: pwd - otherwise it is redundant to check if pwd is null at line 405
• ./source3/torture/nsstest.c:433 [error] - Possible null pointer dereference: grp - otherwise it is redundant to check if grp is null at line 434
• ./source3/torture/nsstest.c:196 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./source3/torture/nsstest.c:234 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./source3/torture/nsstest.c:273 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./source3/utils/net_afs.c:62 [error] - Resource leak: fd
• ./source3/utils/net_usershare.c:900 [error] - Resource leak: tmpfd
• ./source3/utils/smbfilter.c:46 [error] - Resource leak: fd
• ./source3/utils/smbget.c:404 [error] - Resource leak: localhandle
• ./source4/client/tree.c:166 [error] - Dangerous usage of 'path' (strncpy doesn't always 0-terminate it)
• ./source4/dsdb/samdb/ldb_modules/extended_dn_out.c:248 [error] - Possible null pointer dereference: ares - otherwise it is redundant to check if ares is null at line 254
• ./source4/dsdb/samdb/ldb_modules/extended_dn_out.c:624 [error] - Possible null pointer dereference: dereference_control - otherwise it is redundant to check if dereference_control is null at line 626
• ./source4/heimdal/lib/asn1/asn1_gen.c:147 [error] - Memory leak: fnout
• ./source4/heimdal/lib/asn1/asn1parse.c:1646 [error] - Memory leak: yyptr
• ./source4/heimdal/lib/asn1/gen.c:185 [error] - Memory leak: fn
• ./source4/heimdal/lib/asn1/main.c:156 [error] - Common realloc mistake: "arg" nulled but not freed upon failure
• ./source4/heimdal/lib/com_err/parse.c:1428 [error] - Common realloc mistake: "prefix" nulled but not freed upon failure
• ./source4/heimdal/lib/com_err/parse.c:1263 [error] - Memory leak: yyptr
• ./source4/heimdal/lib/gssapi/mech/gss_krb5.c:403 [error] - Memory leak: ctx
• ./source4/heimdal/lib/hx509/ks_file.c:483 [error] - Mismatching allocation and deallocation: f
• ./source4/heimdal/lib/hx509/name.c:232 [error] - Memory leak: oidname
• ./source4/heimdal/lib/hx509/name.c:337 [error] - Uninitialized variable: len
• ./source4/heimdal/lib/hx509/name.c:344 [error] - Uninitialized variable: len
• ./source4/heimdal/lib/hx509/name.c:347 [error] - Uninitialized variable: len
• ./source4/heimdal/lib/hx509/name.c:350 [error] - Uninitialized variable: len
• ./source4/heimdal/lib/hx509/sel-gram.c:1251 [error] - Memory leak: yyptr
• ./source4/heimdal/lib/krb5/crypto.c:2174 [error] - Uninitialized variable: k1_c_data
• ./source4/heimdal/lib/krb5/crypto.c:2238 [error] - Uninitialized variable: k1_c_data
• ./source4/heimdal/lib/krb5/get_cred.c:1437 [error] - Memory leak: out
• ./source4/heimdal/lib/krb5/set_default_realm.c:86 [error] - Memory leak: realms
• ./source4/heimdal/lib/krb5/v4_glue.c:154 [error] - Memory leak: path
• ./source4/heimdal/lib/krb5/v4_glue.c:302 [error] - Memory leak: path
• ./source4/lib/ldb/ldb_tdb/ldb_index.c:274 [error] - Uninitialized variable: ret
• ./source4/lib/ldb/tools/ldbedit.c:323 [error] - Possible null pointer dereference: result - otherwise it is redundant to check if result is null at line 325
• ./source4/lib/registry/dir.c:80 [error] - Resource leak: d
• ./source4/lib/registry/dir.c:372 [error] - Resource leak: d
• ./source4/lib/registry/hive.c:64 [error] - Resource leak: fd
• ./source4/ntvfs/ipc/ipc_rap.c:289 [error] - instance of "rap_heap_save" object destroyed immediately
• ./source4/ntvfs/ipc/ipc_rap.c:371 [error] - instance of "rap_heap_save" object destroyed immediately
• ./source4/rpc_server/netlogon/dcerpc_netlogon.c:1172 [error] - Memory leak: temp_str
• ./source4/smb_server/smb/reply.c:817 [error] - Uninitialized variable: req
• ./source4/smb_server/smb/search.c:85 [error] - Uninitialized variable: req
• ./source4/smb_server/smb/search.c:100 [error] - Uninitialized variable: req

Note: this report is incomplete, which means that an error ocurred while checking this package and not all of the code was analysed.

---