Automated Code Analysis

cppcheck analysis of slurm-llnl_2.2.0-1.dsc

• ./src/api/pmi.c:868 [error] - Common realloc mistake: "kvs_recs" nulled but not freed upon failure
• ./src/common/daemonize.c:97 [error] - Allocation with open, if doesn't release it.
• ./src/common/hostlist.c:2463 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./src/common/hostlist.c:3016 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./src/common/hostlist.c:3320 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./src/common/log.c:940 [error] - instance of "fatal_cleanup" object destroyed immediately
• ./src/common/xmalloc.c:158 [error] - Common realloc mistake: "p" nulled but not freed upon failure
• ./src/common/xmalloc.c:214 [error] - Common realloc mistake: "p" nulled but not freed upon failure
• ./src/plugins/accounting_storage/filetxt/filetxt_jobacct_process.c:604 [style] - Redundant assignment of "type" in switch
• ./src/plugins/accounting_storage/filetxt/filetxt_jobacct_process.c:605 [style] - Redundant assignment of "j" in switch
• ./src/plugins/jobcomp/filetxt/filetxt_jobcomp_process.c:121 [error] - Possible null pointer dereference: temp
• ./src/plugins/jobcomp/filetxt/filetxt_jobcomp_process.c:136 [error] - Possible null pointer dereference: temp
• ./src/plugins/proctrack/linuxproc/kill_tree.c:162 [error] - Resource leak: dir
• ./src/sacctmgr/cluster_functions.c:1116 [error] - Resource leak: fd
• ./src/slurmctld/job_mgr.c:3584 [error] - Resource leak: fd
• ./src/slurmctld/job_mgr.c:3724 [error] - Resource leak: fd
• ./src/slurmctld/power_save.c:298 [error] - Dangerous usage of 'program' (strncpy doesn't always 0-terminate it)
• ./src/slurmctld/trigger_mgr.c:1327 [error] - Dangerous usage of 'program' (strncpy doesn't always 0-terminate it)
• ./src/slurmd/slurmd/read_proc.c:328 [error] - Resource leak: proc_fs
• ./src/smap/configure_functions.c:1503 [error] - Uninitialized variable: com
• ./testsuite/expect/test1.34.prog.c:32 [error] - Possible null pointer dereference: buffer

---