Automated Code Analysis

cppcheck analysis of spring_0.81.2.1+dfsg1-6.dsc

• ./rts/ExternalAI/AISCommands.cpp:815 [style] - Redundant assignment of "internalUnitCommandTopic" in switch
• ./rts/ExternalAI/AISCommands.cpp:1043 [style] - Redundant assignment of "aiCommandTopic" in switch
• ./rts/ExternalAI/SSkirmishAICallbackImpl.cpp:1320 [error] - Possible null pointer dereference: tmpMap
• ./rts/Game/Game.cpp:2177 [error] - Null pointer dereference
• ./rts/Game/Game.cpp:2184 [error] - Division by zero
• ./rts/Game/WaitCommandsAI.cpp:1059 [error] - Same iterator is used with both unblockSet and waitUnits
• ./rts/Game/WaitCommandsAI.cpp:1059 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./rts/Lua/LuaOpenGL.cpp:4672 [error] - Buffer access out-of-bounds: matrix
• ./rts/Lua/LuaOpenGL.cpp:4703 [error] - Buffer access out-of-bounds: matrix
• ./rts/Rendering/FontTexture.cpp:401 [error] - Resource leak: specFile
• ./rts/Rendering/GroundDecalHandler.cpp:1148 [error] - Memory leak: tt
• ./rts/Sim/Units/UnitDefHandler.cpp:978 [error] - Memory leak: originalMap
• ./rts/System/MemPool.cpp:36 [error] - Data is allocated but not initialized: newBlock
• ./rts/System/Platform/Win/CrashHandler.cpp:41 [error] - Null pointer dereference
• ./rts/System/SpringApp.cpp:918 [error] - Invalid number of character ({) when these macros are defined: 'USE_GML'.
• ./rts/lib/gml/gmlfun.h:1312 [error] - Invalid number of character ({) when these macros are defined: 'USE_GML;_WIN32'.
• ./rts/lib/hpiutil2/hpiutil.cpp:90 [error] - Deallocating a deallocated pointer: altname
• ./rts/lib/lua/src/lparser.cpp:359 [error] - Possible null pointer dereference: fs - otherwise it is redundant to check if fs is null at line 379
• ./rts/lib/lua/src/lparser.cpp:375 [error] - Possible null pointer dereference: fs - otherwise it is redundant to check if fs is null at line 379
• ./rts/lib/minizip/unzip.c:522 [error] - Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 523
• ./rts/lib/minizip/unzip.c:1095 [error] - Possible null pointer dereference: pfile_in_zip_read_info - otherwise it is redundant to check if pfile_in_zip_read_info is null at line 1097

---