Automated Code Analysis

cppcheck analysis of wesnoth-1.9_1.9.2-1.dsc

• ./src/config.hpp:382 [error] - Return of the address of an auto-variable
• ./src/tstring.hpp:104 [error] - Returning pointer to temporary
• ./src/tstring.hpp:172 [error] - Returning reference to temporary
• ./src/tstring.hpp:175 [error] - Returning reference to temporary
• ./src/tstring.hpp:173 [error] - Returning pointer to temporary
• ./src/addon/validation.cpp:149 [style] - The iterator incrementing is suspicious - it is incremented at line 149 and then at line 147 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/editor/editor_controller.cpp:359 [error] - instance of "map_context_refresher" object destroyed immediately
• ./src/variable.hpp:127 [error] - Return of the address of an auto-variable
• ./src/generate_report.cpp:217 [style] - The iterator incrementing is suspicious - it is incremented at line 217 and then at line 212 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/generate_report.cpp:492 [style] - The iterator incrementing is suspicious - it is incremented at line 492 and then at line 488 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/gui/widgets/list.cpp:208 [error] - Uninitialized variable: resize_needed
• ./src/gui/widgets/list.cpp:242 [error] - Uninitialized variable: resize_needed
• ./src/help.cpp:1511 [style] - The iterator incrementing is suspicious - it is incremented at line 1511 and then at line 1501 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/formatter.hpp:52 [error] - Returning pointer to temporary
• ./src/poolalloc.c:451 [error] - Common realloc mistake: "items" nulled but not freed upon failure
• ./src/terrain_filter.cpp:423 [error] - Iterator 'intersect_itor' becomes invalid when deleted by value from 'xy_set'
• ./utils/wesnoth-attack-sim.c:438 [error] - Memory leak: res_def

---