Automated Code Analysis

cppcheck analysis of wesnoth-1.9_1.9.5-1.dsc

• ./src/config.hpp:379 [error] - Return of the address of an auto-variable
• ./src/tstring.hpp:104 [error] - Returning pointer to temporary
• ./src/tstring.hpp:172 [error] - Returning reference to temporary
• ./src/tstring.hpp:175 [error] - Returning reference to temporary
• ./src/tstring.hpp:173 [error] - Returning pointer to temporary
• ./src/addon/validation.cpp:129 [style] - The iterator incrementing is suspicious - it is incremented at line 129 and then at line 127 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/ai/lua/core.cpp:71 [error] - Returning reference to temporary
• ./src/editor/editor_controller.cpp:358 [error] - instance of "map_context_refresher" object destroyed immediately
• ./src/variable.hpp:121 [error] - Return of the address of an auto-variable
• ./src/gui/widgets/list.cpp:208 [error] - Uninitialized variable: resize_needed
• ./src/gui/widgets/list.cpp:242 [error] - Uninitialized variable: resize_needed
• ./src/help.cpp:1514 [style] - The iterator incrementing is suspicious - it is incremented at line 1514 and then at line 1504 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/poolalloc.c:451 [error] - Common realloc mistake: "items" nulled but not freed upon failure
• ./src/terrain_filter.cpp:423 [error] - Iterator 'intersect_itor' becomes invalid when deleted by value from 'xy_set'
• ./utils/wesnoth-attack-sim.c:438 [error] - Memory leak: res_def

---