Automated Code Analysis

cppcheck analysis of xpilot-ng_4.7.3-1.2.dsc

• ./contrib/maps2image/bdf2c.c:174 [error] - Resource leak: fl
• ./contrib/mapzip/mapzip.c:67 [error] - Resource leak: in
• ./src/client/NT/bitmaps.c:102 [error] - Common realloc mistake: "pixmaps" nulled but not freed upon failure
• ./src/client/NT/bitmaps.c:128 [error] - Common realloc mistake: "pixmaps" nulled but not freed upon failure
• ./src/client/NT/configure.c:268 [error] - Common realloc mistake: "config_widget_desc" nulled but not freed upon failure
• ./src/client/NT/configure.c:671 [error] - Common realloc mistake: "color_option_indices" nulled but not freed upon failure
• ./src/client/NT/configure.c:674 [error] - Common realloc mistake: "default_option_indices" nulled but not freed upon failure
• ./src/client/NT/paintdata.c:153 [error] - Common realloc mistake: "rgb_arc_ptr" nulled but not freed upon failure
• ./src/client/NT/widget.c:320 [error] - Common realloc mistake: "widgets" nulled but not freed upon failure
• ./src/client/client.c:1701 [error] - Common realloc mistake: "refuel_ptr" nulled but not freed upon failure
• ./src/client/client.c:1714 [error] - Common realloc mistake: "connector_ptr" nulled but not freed upon failure
• ./src/client/client.c:1727 [error] - Common realloc mistake: "laser_ptr" nulled but not freed upon failure
• ./src/client/client.c:1739 [error] - Common realloc mistake: "missile_ptr" nulled but not freed upon failure
• ./src/client/client.c:1751 [error] - Common realloc mistake: "ball_ptr" nulled but not freed upon failure
• ./src/client/client.c:1804 [error] - Common realloc mistake: "ship_ptr" nulled but not freed upon failure
• ./src/client/client.c:1834 [error] - Common realloc mistake: "mine_ptr" nulled but not freed upon failure
• ./src/client/client.c:1845 [error] - Common realloc mistake: "itemtype_ptr" nulled but not freed upon failure
• ./src/client/client.c:1903 [error] - Common realloc mistake: "wreckage_ptr" nulled but not freed upon failure
• ./src/client/client.c:1916 [error] - Common realloc mistake: "asteroid_ptr" nulled but not freed upon failure
• ./src/client/client.c:1926 [error] - Common realloc mistake: "wormhole_ptr" nulled but not freed upon failure
• ./src/client/client.c:1948 [error] - Common realloc mistake: "ecm_ptr" nulled but not freed upon failure
• ./src/client/client.c:1960 [error] - Common realloc mistake: "trans_ptr" nulled but not freed upon failure
• ./src/client/client.c:1971 [error] - Common realloc mistake: "paused_ptr" nulled but not freed upon failure
• ./src/client/client.c:1983 [error] - Common realloc mistake: "appearing_ptr" nulled but not freed upon failure
• ./src/client/client.c:2001 [error] - Common realloc mistake: "radar_ptr" nulled but not freed upon failure
• ./src/client/client.c:2078 [error] - Common realloc mistake: "vcannon_ptr" nulled but not freed upon failure
• ./src/client/client.c:2089 [error] - Common realloc mistake: "vfuel_ptr" nulled but not freed upon failure
• ./src/client/client.c:2102 [error] - Common realloc mistake: "vbase_ptr" nulled but not freed upon failure
• ./src/client/client.c:2115 [error] - Common realloc mistake: "vdecor_ptr" nulled but not freed upon failure
• ./src/client/clientrank.c:182 [error] - Resource leak: file
• ./src/client/clientrank.c:208 [error] - Resource leak: file
• ./src/client/option.c:379 [error] - Common realloc mistake: "keydefs" nulled but not freed upon failure
• ./src/client/option.c:675 [error] - Common realloc mistake: "options" nulled but not freed upon failure
• ./src/client/option.c:845 [error] - Common realloc mistake: "xpilotrc_lines" nulled but not freed upon failure
• ./src/client/option.c:831 [error] - Common realloc mistake: "xpilotrc_lines" nulled but not freed upon failure
• ./src/client/option.c:1033 [error] - Common realloc mistake: "xpilotrc_lines" nulled but not freed upon failure
• ./src/client/sdl/SDL_console.c:365 [error] - Memory leak: newinfo
• ./src/client/sdl/SDL_console.c:954 [error] - Memory leak: command
• ./src/client/sdl/SDL_gfxPrimitives.c:3313 [error] - Common realloc mistake: "gfxPrimitivesPolyInts" nulled but not freed upon failure
• ./src/client/sdl/glwidgets.c:450 [error] - Common realloc mistake: "scrap" nulled but not freed upon failure
• ./src/mapedit/T_Form.c:91 [error] - Memory leak: label
• ./src/mapedit/T_Handler.c:48 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Handler.c:54 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Handler.c:84 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Handler.c:112 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Handler.c:117 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Handler.c:146 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/T_Popup.c:94 [error] - The given size 3 is mismatching
• ./src/mapedit/T_Popup.c:98 [error] - The given size 7 is mismatching
• ./src/mapedit/T_Popup.c:145 [error] - The given size 3 is mismatching
• ./src/mapedit/T_Popup.c:149 [error] - The given size 7 is mismatching
• ./src/mapedit/file.c:336 [error] - Memory leak: filename
• ./src/mapedit/file.c:382 [error] - Memory leak: mapdir
• ./src/mapedit/file.c:408 [error] - Resource leak: fp
• ./src/mapedit/file.c:872 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/file.c:877 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/file.c:884 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/file.c:887 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/mapedit/tools.c:898 [error] - Undefined behaviour: returnval is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/server/contact.c:343 [error] - Uninitialized variable: key
• ./src/server/frame.c:236 [error] - Common realloc mistake: "radar_ptr" nulled but not freed upon failure
• ./src/server/polygon.c:61 [error] - Common realloc mistake: "groups" nulled but not freed upon failure
• ./src/server/polygon.c:153 [error] - Common realloc mistake: "pdata" nulled but not freed upon failure
• ./src/server/polygon.c:181 [error] - Common realloc mistake: "estyleptr" nulled but not freed upon failure
• ./src/server/polygon.c:182 [error] - Common realloc mistake: "estyleptr" nulled but not freed upon failure
• ./src/server/polygon.c:191 [error] - Common realloc mistake: "edgeptr" nulled but not freed upon failure
• ./src/server/polygon.c:192 [error] - Common realloc mistake: "edgeptr" nulled but not freed upon failure
• ./src/server/polygon.c:242 [error] - Common realloc mistake: "estyleptr" nulled but not freed upon failure
• ./src/server/srecord.c:95 [style] - Redundant assignment of "err" in switch
• ./src/server/srecord.c:142 [style] - Redundant assignment of "err" in switch

---