Automated Code Analysis

cppcheck analysis of xview_3.2p1.4-25.1.dsc

• ./clients/olvwm-4.1/resources.c:1585 [error] - Invalid number of character ({) when these macros are defined: 'DEBUG;OW_I18N_L3'.
• ./clients/textedit/textedit.c:996 [error] - Null pointer dereference
• ./contrib/examples/color/example3.c:81 [error] - Buffer access out-of-bounds: pixel_table
• ./contrib/examples/color/example4.c:138 [error] - Memory leak: cms_colors
• ./contrib/examples/color/example4.c:148 [error] - Memory leak: cms_x_colors
• ./contrib/examples/menus/menu_dir2.c:182 [error] - Resource leak: dirp
• ./contrib/examples/menus/menu_dir2.c:220 [error] - Allocation with malloc, strcpy doesn't release it.
• ./contrib/examples/menus/menu_dir2.c:221 [error] - Allocation with malloc, strcpy doesn't release it.
• ./contrib/examples/panels/item_move.c:244 [error] - Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it)
• ./lib/libxview/base/xv_error.c:171 [error] - Undefined behaviour: msg is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./lib/libxview/canvas/cnvs_input.c:431 [error] - Return of the address of an auto-variable
• ./lib/libxview/canvas/cnvs_input.c:456 [error] - Return of the address of an auto-variable
• ./lib/libxview/notify/ndetpoll.c:63 [error] - Invalid number of character (() when these macros are defined: 'POLL'.
• ./lib/libxview/textsw/txt_line.c:114 [error] - Uninitialized variable: error
• ./lib/libxview/textsw/txt_move.c:560 [error] - Uninitialized variable: shift_left
• ./lib/libxview/textsw/txt_search.c:82 [error] - Uninitialized variable: buf
• ./lib/libxview/textsw/txt_search.c:178 [error] - Uninitialized variable: buf
• ./lib/libxview/ttysw/tty.c:260 [error] - Resource leak: consfd
• ./lib/libxview/ttysw/tty_init.c:931 [error] - Resource leak: tty
• ./lib/libxview/ttysw/tty_main.c:814 [error] - Invalid deallocation
• ./util/cpp/cpp1.c:183 [error] - Invalid number of character ({) when these macros are defined: 'DOCUMENTATION'.
• ./util/msgfmt/msgfmt.c:572 [error] - Resource leak: xdotcf
• ./util/xgettext/xgettext.c:788 [error] - Common realloc mistake: "commentbuf" nulled but not freed upon failure
• ./util/xgettext/xgettext.c:918 [error] - Mismatching allocation and deallocation: commentfp

---