Automated Code Analysis

cppcheck analysis of adonthell_0.3.5-5.dsc

• ./src/audio.cc:369 [error] - Uninitialized variable: have_args
• ./src/event.cc:195 [error] - Uninitialized variable: has_args
• ./src/event_list.cc:143 [error] - Uninitialized variable: type
• ./src/fileops.cc:212 [error] - Uninitialized variable: strl
• ./src/fileops.cc:215 [error] - Uninitialized variable: c
• ./src/fileops.cc:246 [error] - Uninitialized variable: f
• ./src/fileops.cc:375 [error] - Uninitialized variable: vinfo
• ./src/fileops.cc:385 [error] - Uninitialized variable: version
• ./src/image.cc:125 [error] - Uninitialized variable: l
• ./src/image.cc:125 [error] - Uninitialized variable: h
• ./src/image.cc:126 [error] - Uninitialized variable: h
• ./src/landmap.cc:87 [error] - Uninitialized variable: i
• ./src/landmap.cc:114 [error] - Uninitialized variable: n
• ./src/landmap.cc:118 [error] - Uninitialized variable: t
• ./src/mapcharacter.cc:178 [error] - Uninitialized variable: current_move__
• ./src/mapcharacter.cc:193 [error] - Uninitialized variable: b
• ./src/mapview.cc:194 [error] - Uninitialized variable: bo
• ./src/py_callback.cc:125 [error] - Uninitialized variable: has_args
• ./src/storage.cc:100 [style] - The iterator incrementing is suspicious - it is incremented at line 100 and then at line 93 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/win_container.cc:100 [error] - Dereferenced iterator 'i' has been erased
• ./src/win_container.cc:80 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./src/win_container.cc:99 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./src/win_font.cc:94 [error] - Possible null pointer dereference: font - otherwise it is redundant to check if font is null at line 98

---