Automated Code Analysis

cppcheck analysis of aqualung_0.9~beta11-1.dsc

• ./src/core.c:3480 [error] - Memory leak: voladj_arg
• ./src/decoder/dec_mod.c:270 [error] - Dangerous usage of 'buffer' (strncpy doesn't always 0-terminate it)
• ./src/decoder/dec_mod.c:302 [error] - Dangerous usage of 'buffer' (strncpy doesn't always 0-terminate it)
• ./src/decoder/dec_mpeg.c:398 [error] - Memory leak: id3v2
• ./src/file_info.c:603 [error] - Resource leak: f
• ./src/httpc.c:369 [error] - Undefined behaviour: value is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./src/ifp_device.c:815 [error] - Buffer access out-of-bounds: remote_path
• ./src/ifp_device.c:351 [error] - Dangerous usage of 'temp' (strncpy doesn't always 0-terminate it)
• ./src/ifp_device.c:353 [error] - Dangerous usage of 'temp' (strncpy doesn't always 0-terminate it)
• ./src/ifp_device.c:409 [error] - Dangerous usage of 'temp' (strncpy doesn't always 0-terminate it)
• ./src/ifp_device.c:411 [error] - Dangerous usage of 'temp' (strncpy doesn't always 0-terminate it)
• ./src/metadata.c:939 [error] - Memory leak: out
• ./src/metadata_ape.c:226 [error] - Memory leak: item
• ./src/metadata_id3v2.c:244 [error] - Mismatching allocation and deallocation: val1
• ./src/metadata_id3v2.c:247 [error] - Mismatching allocation and deallocation: val2
• ./src/metadata_id3v2.c:277 [error] - Mismatching allocation and deallocation: val
• ./src/metadata_id3v2.c:301 [error] - Mismatching allocation and deallocation: val1
• ./src/metadata_id3v2.c:304 [error] - Mismatching allocation and deallocation: val2
• ./src/metadata_id3v2.c:323 [error] - Mismatching allocation and deallocation: val
• ./src/metadata_id3v2.c:351 [error] - Mismatching allocation and deallocation: descr
• ./src/metadata_id3v2.c:355 [error] - Mismatching allocation and deallocation: comment
• ./src/metadata_id3v2.c:401 [error] - Mismatching allocation and deallocation: mime_type
• ./src/metadata_id3v2.c:404 [error] - Mismatching allocation and deallocation: descr
• ./src/metadata_id3v2.c:453 [error] - Mismatching allocation and deallocation: id
• ./src/metadata_id3v2.c:462 [error] - Mismatching allocation and deallocation: id
• ./src/metadata_id3v2.c:722 [error] - Memory leak: link
• ./src/metadata_id3v2.c:754 [error] - Memory leak: link
• ./src/metadata_id3v2.c:1119 [error] - Deallocating a deallocated pointer: file
• ./src/metadata_ogg.c:416 [error] - Common realloc mistake: "data" nulled but not freed upon failure
• ./src/metadata_ogg.c:706 [error] - Common realloc mistake: "payload" nulled but not freed upon failure
• ./src/metadata_ogg.c:710 [error] - Common realloc mistake: "payload" nulled but not freed upon failure
• ./src/metadata_ogg.c:763 [error] - Common realloc mistake: "vc_entry" nulled but not freed upon failure
• ./src/metadata_ogg.c:767 [error] - Common realloc mistake: "payload" nulled but not freed upon failure
• ./src/metadata_ogg.c:771 [error] - Common realloc mistake: "payload" nulled but not freed upon failure
• ./src/metadata_ogg.c:783 [error] - Common realloc mistake: "payload" nulled but not freed upon failure
• ./src/options.c:4029 [error] - Resource leak: fin
• ./src/playlist.c:5134 [error] - Resource leak: f
• ./src/playlist.c:5347 [error] - Resource leak: f
• ./src/plugin.c:2083 [error] - Resource leak: fin
• ./src/plugin.c:817 [error] - Dangerous usage of 'maker' (strncpy doesn't always 0-terminate it)
• ./src/search.c:239 [error] - Mismatching allocation and deallocation: tmp
• ./src/search.c:264 [error] - Mismatching allocation and deallocation: tmp
• ./src/search.c:300 [error] - Mismatching allocation and deallocation: tmp
• ./src/search.c:325 [error] - Mismatching allocation and deallocation: tmp
• ./src/search.c:361 [error] - Mismatching allocation and deallocation: tmp
• ./src/search.c:386 [error] - Mismatching allocation and deallocation: tmp
• ./src/search_playlist.c:170 [error] - Mismatching allocation and deallocation: tmp
• ./src/store_file.c:1461 [error] - Common realloc mistake: "volumes" nulled but not freed upon failure
• ./src/store_file.c:2052 [error] - Memory leak: file
• ./src/store_podcast.c:360 [error] - Dangerous usage of 'url' (strncpy doesn't always 0-terminate it)
• ./src/utils.c:152 [error] - Common realloc mistake: "cbuf" nulled but not freed upon failure
• ./src/utils.c:161 [error] - Common realloc mistake: "cbuf" nulled but not freed upon failure
• ./src/utils.c:174 [error] - Memory leak: cbuf

---