Automated Code Analysis

cppcheck analysis of asc_2.4.0.0-1.dsc

• ./source/actions/servicecommand.cpp:98 [error] - Throwing exception in invalid state, transferHandler points at deallocated memory
• ./source/oldlzw.cpp:296 [error] - Common realloc mistake: "DecodeBuffer" nulled but not freed upon failure
• ./source/dialogs/attackpanel.cpp:138 [error] - instance of "GetAttackerImage" object destroyed immediately
• ./source/dialogs/attackpanel.cpp:142 [error] - instance of "GetTargetImage" object destroyed immediately
• ./source/dialogs/internalAmmoTransferDialog.cpp:98 [error] - Buffer access out-of-bounds: weaponAmmo
• ./source/dialogs/internalAmmoTransferDialog.cpp:278 [error] - Buffer access out-of-bounds: weaponAmmo
• ./source/dlgraph.cpp:152 [error] - Data is allocated but not initialized: pq
• ./source/dlgraph.cpp:155 [error] - Data is allocated but not initialized: p
• ./source/dlgraph.cpp:211 [error] - Data is allocated but not initialized: p
• ./source/dlgraph.cpp:275 [error] - Data is allocated but not initialized: p
• ./source/dlgraph.cpp:297 [error] - Data is allocated but not initialized: p
• ./source/dlgraph.cpp:321 [error] - Data is allocated but not initialized: pq
• ./source/dlgraph.cpp:325 [error] - Data is allocated but not initialized: p
• ./source/dlg_box.cpp:1408 [error] - Data is allocated but not initialized: buf
• ./source/edglobal.cpp:283 [error] - Mismatching allocation and deallocation: c
• ./source/edglobal.cpp:979 [error] - Null pointer dereference
• ./source/libs/paragui/src/widgets/pgmenubar.cpp:121 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
• ./source/libs/revel/avilib.c:701 [error] - Memory leak: hdrl_data
• ./source/libs/sdl_sound/SDL_sound_internal.h:320 [error] - Invalid number of character ({) when these macros are defined: '__cplusplus'.
• ./source/libs/sdl_sound/SDL_sound_internal.h:320 [error] - Invalid number of character ({) when these macros are defined: 'SOUND_SUPPORTS_OGG;__cplusplus'.
• ./source/libs/sdl_sound/SDL_sound_internal.h:320 [error] - Invalid number of character ({) when these macros are defined: 'SOUND_SUPPORTS_WAV;__cplusplus'.
• ./source/libs/triangul/trimisc.c:122 [error] - Resource leak: infile
• ./source/loadbi3.cpp:1477 [error] - Common realloc mistake: "txtbuffer" nulled but not freed upon failure
• ./source/network/pbem-server-interaction.cpp:30 [error] - Mismatching allocation and deallocation: buffer
• ./source/newfont.cpp:121 [error] - Memory leak: font1
• ./source/spfst.cpp:279 [error] - Possible null pointer dereference: eht - otherwise it is redundant to check if eht is null at line 289
• ./source/tools/bldhex.cpp:159 [error] - Data is allocated but not initialized: buf
• ./source/tools/clearup.cpp:85 [error] - Resource leak: fp
• ./source/tools/convbld.cpp:110 [error] - Memory leak: nm
• ./source/tools/convbld.cpp:110 [error] - Memory leak: pj
• ./source/tools/getcol.cpp:73 [error] - Memory leak: p
• ./source/tools/makebkgr.cpp:54 [error] - Data is allocated but not initialized: buf
• ./source/tools/makebuld.cpp:147 [error] - Data is allocated but not initialized: buf
• ./source/tools/makefont.cpp:448 [error] - Memory leak: szel1
• ./source/tools/makefont.cpp:448 [error] - Memory leak: szel2
• ./source/tools/maketnk2.cpp:159 [error] - Memory leak: ft
• ./source/tools/mntgraph.cpp:262 [error] - Resource leak: fp
• ./source/tools/mount.cpp:199 [error] - Memory leak: buffer
• ./source/tools/mount.cpp:286 [error] - Memory leak: buf

---