Automated Code Analysis

cppcheck analysis of freedink_1.08.20100420-1.dsc

• ./contrib/bmpinspect.c:155 [error] - Resource leak: file
• ./contrib/bmpinspect.c:155 [error] - Memory leak: palette
• ./contrib/dinkdat_inspect.c:51 [error] - Resource leak: f
• ./contrib/ffinspect.c:90 [error] - Resource leak: file
• ./contrib/ffrpack.cpp:130 [error] - Resource leak: fout
• ./contrib/ffrpack.cpp:130 [error] - Memory leak: subfiles
• ./src/SDL_rwops_libzip.c:80 [error] - Common realloc mistake: "errorbuf" nulled but not freed upon failure
• ./src/binreloc.c:253 [error] - Common realloc mistake: "address_string" nulled but not freed upon failure
• ./src/dinkc.c:845 [error] - Buffer access out-of-bounds: callback
• ./src/dinkc_bindings.c:541 [error] - instance of "show_bmp" object destroyed immediately
• ./src/gfx_fonts.c:285 [error] - Memory leak: filename
• ./src/gfx_fonts.c:294 [error] - Memory leak: filename
• ./src/paths.c:291 [error] - Common realloc mistake: "userappdir" nulled but not freed upon failure
• ./src/paths.c:443 [error] - Common realloc mistake: "savedir" nulled but not freed upon failure
• ./test/sdl/SDL_rwops_libzip.c:73 [error] - Common realloc mistake: "errorbuf" nulled but not freed upon failure
• ./test/sdl/embedded_font.c:77 [error] - Buffer overrun possible for long cmd-line args
• ./test/sdl/embedded_font2.c:77 [error] - Buffer overrun possible for long cmd-line args

---