Automated Code Analysis

cppcheck analysis of gdal_1.6.3-4.dsc

• ./frmts/adrg/adrgdataset.cpp:1048 [error] - Memory leak: TILEINDEX
• ./frmts/coasp/coasp_dataset.cpp:199 [error] - Undefined behaviour: pszItemValue is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./frmts/dted/dted_api.c:201 [error] - Memory leak: psDInfo
• ./frmts/dted/dted_api.c:534 [error] - Deallocating a deallocated pointer: pabyRecord
• ./frmts/dted/dted_create.c:181 [error] - Resource leak: fp
• ./frmts/envisat/EnvisatFile.c:1771 [error] - Possible null pointer dereference: entries
• ./frmts/envisat/EnvisatFile.c:264 [error] - Resource leak: fp
• ./frmts/envisat/EnvisatFile.c:286 [error] - Memory leak: self
• ./frmts/envisat/EnvisatFile.c:328 [error] - Memory leak: sph_data
• ./frmts/envisat/EnvisatFile.c:493 [error] - Memory leak: template_data
• ./frmts/envisat/EnvisatFile.c:609 [error] - Memory leak: dsd_text
• ./frmts/envisat/EnvisatFile.c:1784 [error] - Memory leak: entry
• ./frmts/grib/degrib18/degrib/clock.c:2071 [error] - Common realloc mistake: "Stack" nulled but not freed upon failure
• ./frmts/grib/degrib18/degrib/clock.c:2175 [error] - Common realloc mistake: "Rel" nulled but not freed upon failure
• ./frmts/grib/degrib18/degrib/clock.c:2197 [error] - Common realloc mistake: "Rel" nulled but not freed upon failure
• ./frmts/grib/degrib18/degrib/clock.c:2209 [error] - Common realloc mistake: "Rel" nulled but not freed upon failure
• ./frmts/grib/degrib18/degrib/metaparse.cpp:2623 [error] - Common realloc mistake: "freq" nulled but not freed upon failure
• ./frmts/grib/degrib18/degrib/tdlpack.cpp:3255 [error] - Common realloc mistake: "subGroup" nulled but not freed upon failure
• ./frmts/grib/degrib18/g2clib-1.0.4/comunpack.c:198 [error] - Memory leak: ifld
• ./frmts/gtiff/libtiff/tif_jpeg.c:205 [error] - Uninitialized variable: buffer
• ./frmts/gtiff/libtiff/tif_jpeg.c:221 [error] - Uninitialized variable: buffer
• ./frmts/gtiff/libtiff/tif_ojpeg.c:2384 [error] - Uninitialized variable: buffer
• ./frmts/gtiff/libtiff/tif_ojpeg.c:2392 [error] - Uninitialized variable: buffer
• ./frmts/hdf4/hdf-eos/EHapi.c:2307 [error] - Common realloc mistake: "metabuf" nulled but not freed upon failure
• ./frmts/hdf4/hdf-eos/SWapi.c:5391 [error] - Buffer access out-of-bounds: latName
• ./frmts/hdf4/hdf-eos/SWapi.c:6010 [error] - Buffer access out-of-bounds: latName
• ./frmts/hdf4/hdf-eos/SWapi.c:4995 [error] - Memory leak: fillbuf
• ./frmts/hdf4/hdf-eos/SWapi.c:5615 [error] - Memory leak: flag
• ./frmts/hdf4/hdf-eos/SWapi.c:6239 [error] - Memory leak: flag
• ./frmts/ilwis/ilwisdataset.cpp:1846 [error] - Memory leak: sRange
• ./frmts/jp2kak/jp2kakdataset.cpp:2048 [error] - Memory leak: engines
• ./frmts/jp2kak/jp2kakdataset.cpp:2048 [error] - Memory leak: lines
• ./frmts/jpeg/jpgdataset.cpp:1815 [error] - Uninitialized variable: buffer
• ./frmts/jpeg/libjpeg/jerror.c:103 [error] - Uninitialized variable: buffer
• ./frmts/jpeg/libjpeg/jmemmgr.c:1067 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1068 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1069 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1070 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1071 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1072 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1073 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1074 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1075 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1076 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1077 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1080 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1083 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1086 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1087 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1089 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1090 [error] - Possible null pointer dereference: mem
• ./frmts/jpeg/libjpeg/jmemmgr.c:1092 [error] - Possible null pointer dereference: mem
• ./frmts/msgn/msg_reader_core.cpp:239 [error] - Array index -1 is out of bounds
• ./frmts/msgn/msg_reader_core.cpp:240 [error] - Array index -1 is out of bounds
• ./frmts/netcdf/netcdfdataset.cpp:1135 [error] - Uninitialized variable: dfWE
• ./frmts/pcraster/libcsf/kernlcsf.c:113 [error] - Common realloc mistake: "mapList" nulled but not freed upon failure
• ./frmts/sgi/sgidataset.cpp:260 [error] - Possible null pointer dereference: poDS
• ./frmts/tsx/tsxdataset.cpp:482 [error] - Memory leak: pszGeorefFile
• ./frmts/zlib/gzio.c:149 [error] - Memory leak: s.path
• ./ogr/ogrsf_frmts/dgn/dgnwrite.cpp:1076 [error] - Buffer access out-of-bounds: psArc.quat
• ./ogr/ogrsf_frmts/dgn/dgnwrite.cpp:1297 [error] - Buffer access out-of-bounds: psCone.quat
• ./ogr/ogrsf_frmts/geojson/jsonc/json_util.c:71 [error] - Resource leak: fd
• ./ogr/ogrsf_frmts/geojson/jsonc/json_util.c:106 [error] - Resource leak: fd
• ./ogr/ogrsf_frmts/idb/ogridblayer.cpp:346 [style] - Redundant assignment of "pszMessage" in switch
• ./ogr/ogrsf_frmts/mitab/mitab_coordsys.cpp:769 [error] - Buffer access out-of-bounds
• ./ogr/ogrsf_frmts/mitab/mitab_geometry.cpp:223 [error] - Memory leak: xintersect
• ./ogr/ogrsf_frmts/ntf/ntf_generic.cpp:402 [error] - Possible null pointer dereference: panLinks
• ./ogr/ogrsf_frmts/ntf/ntf_generic.cpp:454 [error] - Possible null pointer dereference: panParts
• ./ogr/ogrsf_frmts/shape/dbfopen.c:676 [error] - Memory leak: pszBasename
• ./ogr/ogrsf_frmts/shape/shape2ogr.cpp:255 [error] - Possible null pointer dereference: poOGRPoly
• ./ogr/ogrsf_frmts/shape/shpopen.c:849 [error] - Memory leak: pszBasename
• ./ogr/swq.c:654 [error] - Memory leak: op
• ./port/cpl_conv.cpp:1416 [error] - Dangerous usage of 'szAltPath' (strncpy doesn't always 0-terminate it)
• ./port/cpl_minizip_unzip.cpp:756 [error] - Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 757
• ./port/cpl_minizip_unzip.cpp:1356 [error] - Possible null pointer dereference: pfile_in_zip_read_info - otherwise it is redundant to check if pfile_in_zip_read_info is null at line 1358
• ./pymod/gdal_wrap.c:354 [error] - Common realloc mistake: "SwigPtrTable" nulled but not freed upon failure
• ./pymod/gdal_wrap.c:1006 [error] - Uninitialized variable: obj
• ./swig/php/gdal_wrap.cpp:1841 [error] - Uninitialized variable: _v

---