Automated Code Analysis

cppcheck analysis of kst_1.7.0-1.1.dsc

• ./kst/src/datasources/ascii/ascii.cpp:340 [error] - Common realloc mistake: "_rowIndex" nulled but not freed upon failure
• ./kst/src/datasources/ascii/ascii.cpp:489 [error] - Common realloc mistake: "_tmpBuf" nulled but not freed upon failure
• ./kst/src/datasources/dirfile/getdata.c:1897 [error] - Resource leak: fp
• ./kst/src/datasources/dirfile/getdata.c:2154 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/src/datasources/dirfile/getdata.c:2191 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/src/datasources/dirfile/getdata.c:2235 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/src/datasources/dirfile/getdata.c:2653 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/src/datasources/frame/creaddata.c:316 [error] - Resource leak: fp
• ./kst/src/datasources/frame/creaddata.c:376 [error] - Resource leak: fp
• ./kst/src/datasources/frame/creaddata.c:676 [error] - Resource leak: fp
• ./kst/src/datasources/frame/readdata.c:370 [error] - Common realloc mistake: "in_buf" nulled but not freed upon failure
• ./kst/src/datasources/frame/readdata.c:435 [error] - Common realloc mistake: "tempCBuff" nulled but not freed upon failure
• ./kst/src/datasources/frame/readdata.c:249 [error] - Resource leak: fp
• ./kst/src/datasources/frame/readdata.c:309 [error] - Resource leak: fp
• ./kst/src/datasources/frame/readdata.c:886 [error] - Memory leak: data_buffer
• ./kst/src/datasources/healpix/healpix.cpp:321 [error] - Memory leak: hits
• ./kst/src/datasources/healpix/healpix.cpp:345 [error] - Memory leak: mapdata
• ./kst/src/datasources/healpix/healpix.cpp:431 [error] - Memory leak: comptheta
• ./kst/src/datasources/healpix/healpix.cpp:769 [error] - Memory leak: mapdata
• ./kst/src/extdate/kstextdatetime.h:48 [error] - instance of "ExtDate" object destroyed immediately
• ./kst/src/extdate/kstextdatetime.cpp:25 [error] - Invalid number of character ({) when these macros are defined: 'QT_NO_DATASTREAM'.
• ./kst/src/extensions/elog/elogthreadsubmit.cpp:171 [error] - Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
• ./kst/src/extensions/elog/elogthreadsubmit.cpp:208 [error] - Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
• ./kst/src/extensions/js/elogthreadsubmit.cpp:209 [error] - Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
• ./kst/src/extensions/js/elogthreadsubmit.cpp:246 [error] - Dangerous usage of 'str' (strncpy doesn't always 0-terminate it)
• ./kst/src/extensions/rana/linearitygainisolation_i.cpp:216 [error] - Memory leak: pXErr
• ./kst/src/libkst/kstrvector.cpp:599 [error] - Common realloc mistake: "_aveReadBuf" nulled but not freed upon failure
• ./kst/src/libkstapp/kstdoc.cpp:1328 [error] - Resource leak: fd
• ./kst/src/libkstapp/kstiface_impl.cpp:1195 [style] - Redundant assignment of "normtype" in switch
• ./kst/src/libkstkmdi/kdockwidget.cpp:2931 [error] - Possible null pointer dereference: pMain
• ./kst/src/libkstkmdi/kdockwidget.cpp:2932 [error] - Possible null pointer dereference: pMain
• ./kst/src/libkstkmdi/kdockwidget.cpp:2936 [error] - Possible null pointer dereference: pTLDockWdg
• ./kst/src/libkstkmdi/kdockwidget.cpp:2937 [error] - Possible null pointer dereference: pTLDockWdg
• ./kst/src/libkstkmdi/kdockwidget.cpp:2945 [error] - Possible null pointer dereference: pMain
• ./kst/src/libkstkmdi/kdockwidget.cpp:2947 [error] - Possible null pointer dereference: pTLDockWdg
• ./kst/tests/dirfile_replay/getdata.c:1713 [error] - Resource leak: fp
• ./kst/tests/dirfile_replay/getdata.c:1949 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/tests/dirfile_replay/getdata.c:1986 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/tests/dirfile_replay/getdata.c:2033 [error] - Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it)
• ./kst/tests/dirfile_replay/replay.c:143 [error] - Memory leak: fp_out

---