Automated Code Analysis

cppcheck analysis of nethack_3.4.3-12.1.dsc

• ./src/alloc.c:44 [error] - Return of the address of an auto-variable
• ./src/cmd.c:2383 [error] - Returning pointer to local array variable
• ./src/do_name.c:619 [error] - Returning pointer to local array variable
• ./src/do_name.c:652 [error] - Returning pointer to local array variable
• ./src/do_name.c:656 [error] - Returning pointer to local array variable
• ./src/do_name.c:661 [error] - Returning pointer to local array variable
• ./src/do_name.c:738 [error] - Returning pointer to local array variable
• ./src/do_name.c:743 [error] - Returning pointer to local array variable
• ./src/do_name.c:748 [error] - Returning pointer to local array variable
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'AMIGA'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'GOLDOBJ'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'LINT'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'MAC'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'NO_SIGNAL'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'SYSV'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./src/end.c:310 [error] - Invalid number of character ({) when these macros are defined: 'WIZARD'.
• ./src/invent.c:1640 [error] - Returning pointer to local array variable
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'MAC;OVLB'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB;STEED'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB;WIZARD'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMIFLUSH;AMII_GRAPHICS'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;CLIPPING'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;HACKFONT'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;INTUI_NEW_LOOK'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;OPT_DISPMAP'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AZTEC_C'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'CHDIR'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'INTUI_NEW_LOOK;__SASC'.
• ./sys/amiga/winami.c:778 [error] - Invalid number of character ({) when these macros are defined: 'AMIGA_INTUITION;EXTMENU'.
• ./sys/atari/tos.c:275 [error] - Resource leak: fromfd
• ./sys/msdos/pckeys.c:84 [error] - Invalid number of character ({) when these macros are defined: 'MK_PTR;MSDOS;USE_TILES'.
• ./sys/msdos/pckeys.c:84 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;OBSOLETE;USE_TILES'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MFLOPPY'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MFLOPPY;TOS'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MICRO'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MOVERLAY'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;NO_TERMS'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'OS2_CODEVIEW'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'TOS'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'TOS;__MINT__'.
• ./sys/share/pcsys.c:424 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./sys/share/pctty.c:83 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/pctty.c:83 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;NO_TERMS'.
• ./sys/share/pctty.c:83 [error] - Invalid number of character ({) when these macros are defined: 'TIMED_DELAY;_MSC_VER'.
• ./sys/share/pctty.c:83 [error] - Invalid number of character ({) when these macros are defined: 'TOS'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'BSD;POSIX_TYPES'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'LINT'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'LINUX'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_JOB_CONTROL'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_JOB_CONTROL;VSUSP'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_TYPES'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'TAB3'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'TCSETS'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'TEXTCOLOR;TTY_GRAPHICS;_M_UNIX'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'TEXTCOLOR;TTY_GRAPHICS;__linux__'.
• ./sys/share/unixtty.c:449 [error] - Invalid number of character ({) when these macros are defined: 'TTY_GRAPHICS'.
• ./sys/share/uudecode.c:169 [error] - Resource leak: in
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'MAIL'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'SAVE_ON_FATAL_ERROR'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'TIMED_DELAY'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'USE_QIO_INPUT'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: '__GNUC__'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'APSTUDIO_INVOKED'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'APSTUDIO_INVOKED;APSTUDIO_READONLY_SYMBOLS'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'OVL0'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIN_CE_POCKETPC'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIN_CE_SMARTPHONE'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIZARD'.
• ./sys/winnt/nttty.c:937 [error] - Invalid number of character ({) when these macros are defined: 'WIN32CON'.
• ./sys/winnt/winnt.c:222 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./sys/winnt/winnt.c:222 [error] - Invalid number of character ({) when these macros are defined: 'WIN32;WIZARD'.
• ./util/dgn_main.c:87 [error] - Buffer overrun possible for long cmd-line args
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'ALLOCA_HACK'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'AZTEC'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'SYSV'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'VMS'.
• ./util/recover.c:287 [error] - Resource leak: lfd
• ./win/X11/winmesg.c:601 [error] - Uninitialized variable: wp
• ./win/win32/mhsplash.c:116 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./win/win32/mhsplash.c:147 [error] - Common realloc mistake: "buf" nulled but not freed upon failure

---