Automated Code Analysis

cppcheck analysis of openbabel_2.2.3-1.dsc

• ./src/GUI/optswx.cpp:344 [style] - The iterator incrementing is suspicious - it is incremented at line 344 and then at line 305 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/alias.cpp:46 [error] - Memory leak: txt
• ./src/chains.cpp:415 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:416 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:417 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:418 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:419 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:420 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:421 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:422 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:423 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:424 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:425 [error] - Possible null pointer dereference: result
• ./src/chains.cpp:426 [error] - Possible null pointer dereference: result
• ./src/forcefield.cpp:2281 [error] - Memory leak: origCoords
• ./src/formats/inchi102/ichicans.c:188 [error] - Possible null pointer dereference: visited - otherwise it is redundant to check if visited is null at line 189
• ./src/formats/inchi102/ichiprt2.c:600 [error] - Possible null pointer dereference: nNumH - otherwise it is redundant to check if nNumH is null at line 601
• ./src/formats/inchi102/ichiprt3.c:3044 [error] - Uninitialized variable: Stereo
• ./src/formats/inchi102/ichiprt3.c:3068 [error] - Uninitialized variable: Stereo
• ./src/formats/inchi102/ichister.c:1991 [error] - Invalid number of character (() when these macros are defined: ''.
• ./src/formats/inchi102/ichister.c:1991 [error] - Invalid number of character (() when these macros are defined: 'NEVER'.
• ./src/formats/inchi102/ichister.c:1991 [error] - Invalid number of character (() when these macros are defined: '_DEBUG'.
• ./src/formats/inchi102/ichitaut.c:524 [error] - Possible null pointer dereference: nGroupNewNumber - otherwise it is redundant to check if nGroupNewNumber is null at line 525
• ./src/formats/inchi102/ichitaut.c:602 [error] - Possible null pointer dereference: nGroupNewNumber - otherwise it is redundant to check if nGroupNewNumber is null at line 603
• ./src/formats/inchi102/ichitaut.c:610 [error] - Possible null pointer dereference: nGroupNumber - otherwise it is redundant to check if nGroupNumber is null at line 611
• ./src/formats/inchi102/ichitaut.c:2061 [error] - Possible null pointer dereference: cPair - otherwise it is redundant to check if cPair is null at line 2062
• ./src/formats/inchi102/ichitaut.c:2267 [error] - Possible null pointer dereference: EndPoint - otherwise it is redundant to check if EndPoint is null at line 2268
• ./src/formats/pngformat.cpp:186 [error] - Memory leak: pCompTxt
• ./src/formats/xml/cmlformat.cpp:624 [style] - The iterator incrementing is suspicious - it is incremented at line 624 and then at line 523 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/formats/xml/cmlformat.cpp:996 [style] - The iterator incrementing is suspicious - it is incremented at line 996 and then at line 989 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/formats/xml/xml.cpp:346 [error] - Possible null pointer dereference: ofs - otherwise it is redundant to check if ofs is null at line 347
• ./src/formats/xtcformat.cpp:926 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./src/formats/xtcformat.cpp:672 [error] - Memory leak: ip
• ./src/mol.cpp:2741 [error] - Memory leak: bond
• ./src/parsmart.cpp:1741 [error] - Possible null pointer dereference: result - otherwise it is redundant to check if result is null at line 1742
• ./src/patty.cpp:112 [error] - Possible null pointer dereference: ifsP

---