Automated Code Analysis

cppcheck analysis of openldap_2.4.23-7.dsc

• ./contrib/slapd-modules/comp_match/certificate.h:376 [error] - Invalid number of character ({) when these macros are defined: '__cplusplus'.
• ./contrib/slapd-modules/comp_match/authorityKeyIdentifier.h:324 [error] - Invalid number of character ({) when these macros are defined: '__cplusplus'.
• ./contrib/slapd-modules/comp_match/componentlib.c:2106 [error] - Possible null pointer dereference: ad_type - otherwise it is redundant to check if ad_type is null at line 2109
• ./contrib/slapd-modules/comp_match/crl.h:356 [error] - Invalid number of character ({) when these macros are defined: '__cplusplus'.
• ./contrib/slapd-modules/comp_match/init.c:606 [error] - Possible null pointer dereference: csi_attr - otherwise it is redundant to check if csi_attr is null at line 607
• ./contrib/slapd-modules/dsaschema/dsaschema.c:392 [error] - Common realloc mistake: "line" nulled but not freed upon failure
• ./contrib/slapd-modules/dsaschema/dsaschema.c:424 [error] - Common realloc mistake: "line" nulled but not freed upon failure
• ./contrib/slapd-modules/dsaschema/dsaschema.c:185 [error] - Resource leak: fp
• ./contrib/slapd-modules/dsaschema/dsaschema.c:189 [error] - Memory leak: saveline
• ./libraries/liblunicode/ucdata/ucgendat.c:543 [error] - Common realloc mistake: "title" nulled but not freed upon failure
• ./libraries/liblunicode/ucdata/ucgendat.c:590 [error] - Common realloc mistake: "upper" nulled but not freed upon failure
• ./libraries/liblunicode/ucdata/ucgendat.c:637 [error] - Common realloc mistake: "lower" nulled but not freed upon failure
• ./libraries/liblunicode/ucdata/ucgendat.c:672 [error] - Common realloc mistake: "ccl" nulled but not freed upon failure
• ./libraries/liblunicode/ucdata/ucgendat.c:753 [error] - Common realloc mistake: "nums" nulled but not freed upon failure
• ./libraries/liblunicode/ucdata/ucgendat.c:791 [error] - Common realloc mistake: "ncodes" nulled but not freed upon failure
• ./libraries/liblutil/passfile.c:68 [error] - Resource leak: f
• ./servers/slapd/back-bdb/add.c:520 [error] - Null pointer dereference
• ./servers/slapd/back-bdb/add.c:521 [error] - Null pointer dereference
• ./servers/slapd/back-ndb/add.cpp:340 [error] - Null pointer dereference
• ./servers/slapd/back-ndb/add.cpp:341 [error] - Null pointer dereference
• ./servers/slapd/back-null/null.c:204 [error] - Null pointer dereference
• ./servers/slapd/back-null/null.c:205 [error] - Null pointer dereference
• ./servers/slapd/schema_check.c:254 [error] - Possible null pointer dereference: cr - otherwise it is redundant to check if cr is null at line 257
• ./servers/slapd/schema_init.c:5575 [error] - Uninitialized variable: parts
• ./servers/slapd/syncrepl.c:3657 [error] - Uninitialized variable: a
• ./tests/progs/slapd-bind.c:478 [error] - Common realloc mistake: "dns" nulled but not freed upon failure
• ./tests/progs/slapd-bind.c:483 [error] - Common realloc mistake: "creds" nulled but not freed upon failure
• ./tests/progs/slapd-search.c:330 [error] - Common realloc mistake: "values" nulled but not freed upon failure

---