Automated Code Analysis

cppcheck analysis of openswan_2.6.28+dfsg-5.dsc

• ./contrib/lucent/UDP501encap.c:198 [error] - No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./lib/libbsdpfkey/ipsec_dump_policy.c:165 [error] - Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.
• ./lib/libcrypto/liboswcrypto/cryptodev.c:241 [error] - Resource leak: fd
• ./lib/libdns/rdata/generic/soa_6.c:141 [error] - Unusual pointer arithmetic
• ./lib/libopenswan/optionsfrom.c:101 [error] - Resource leak: f
• ./lib/libopenswan/oswconf.c:198 [error] - Resource leak: fd
• ./lib/libpluto/readwhackmsg.c:82 [error] - Resource leak: record
• ./linux/net/ipsec/datatot.c:62 [style] - Redundant assignment of "format" in switch
• ./linux/net/ipsec/ipsec_tunnel.c:1986 [error] - Memory leak: priv_dev
• ./programs/pluto/ikev1.c:2360 [error] - Possible null pointer dereference: st - otherwise it is redundant to check if st is null at line 2364
• ./programs/pluto/keys.c:485 [error] - Uninitialized variable: pathlen
• ./programs/pluto/plutomain.c:780 [error] - Allocation with open, if doesn't release it.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'DYNAMICDNS'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'HAS_SUN_LEN'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_LIBNSS'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_NM'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_STATSD'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'HAVE_UDPFROMTO'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'IPSECPOLICY'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'IPSEC_PLUTO_PCRC_DEBUG'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'IPV6_USE_MIN_MTU'.
• ./programs/pluto/server.c:1195 [error] - Invalid number of character ({) when these macros are defined: 'IP_RECVERR;MSG_ERRQUEUE'.
• ./testing/crypto/pk-dh-03/modp-case0.c:221 [error] - Uninitialized variable: gtothex
• ./testing/crypto/pk-dh-03/modp-case1.c:219 [error] - Uninitialized variable: gtothex
• ./testing/crypto/pk-dh-03/modp-case1.c:224 [error] - Uninitialized variable: gtothex
• ./testing/utils/ike-aggr-dos/ike-aggr-dos.c:188 [error] - Uninitialized variable: chksum
• ./testing/utils/siocprivate/tncfg.c:53 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./testing/utils/siocprivate/tncfg.c:53 [error] - Invalid number of character ({) when these macros are defined: 'NET_21'.
• ./testing/utils/uml_netjig/port.c:401 [error] - Memory leak: np
• ./testing/utils/uml_netjig/uml_netjig.c:455 [error] - Common realloc mistake: "l_fds" nulled but not freed upon failure
• ./testing/utils/uml_netjig/uml_netjig.c:460 [error] - Common realloc mistake: "l_fd_array" nulled but not freed upon failure
• ./testing/utils/uml_netjig/uml_switch.c:225 [error] - Common realloc mistake: "l_fds" nulled but not freed upon failure
• ./testing/utils/uml_netjig/uml_switch.c:230 [error] - Common realloc mistake: "l_fd_array" nulled but not freed upon failure

---