Automated Code Analysis

cppcheck analysis of saga_2.0.4+dfsg-2.dsc

• ./src/modules/grid/grid_analysis/Grid_AHP.cpp:125 [error] - Uninitialized variable: pCoefs
• ./src/modules/grid/grid_analysis/Grid_Pattern.cpp:168 [error] - Memory leak: iValues
• ./src/modules/grid/grid_analysis/owa.cpp:124 [error] - Uninitialized variable: pCoefs
• ./src/modules/grid/grid_analysis/owa.cpp:125 [error] - Uninitialized variable: pOrderedValues
• ./src/modules/pointcloud/pointcloud_tools/pc_from_shapes.cpp:173 [error] - Mismatching allocation and deallocation: Fields
• ./src/modules/shapes/shapes_polygons/Polygon_Clipper.cpp:924 [error] - Possible null pointer dereference: v - otherwise it is redundant to check if v is null at line 925
• ./src/modules/shapes/shapes_polygons/Polygon_Clipper.cpp:1897 [error] - Possible null pointer dereference: vtx - otherwise it is redundant to check if vtx is null at line 1900
• ./src/modules/shapes/shapes_tools/Polygon_Clipper.cpp:924 [error] - Possible null pointer dereference: v - otherwise it is redundant to check if v is null at line 925
• ./src/modules/shapes/shapes_tools/Polygon_Clipper.cpp:1897 [error] - Possible null pointer dereference: vtx - otherwise it is redundant to check if vtx is null at line 1900
• ./src/modules/shapes/shapes_tools/QueryBuilder.cpp:114 [error] - Memory leak: pRecordWasSelected
• ./src/modules/shapes/shapes_tools/SearchInTable.cpp:128 [error] - Mismatching allocation and deallocation: WasSelected
• ./src/modules/shapes/shapes_tools/SelectByTheme.cpp:124 [error] - Mismatching allocation and deallocation: WasSelected
• ./src/modules_geostatistics/geostatistics/geostatistics_grid/GSGrid_Variance.cpp:205 [error] - Common realloc mistake: "x_diff" nulled but not freed upon failure
• ./src/modules_geostatistics/geostatistics/geostatistics_grid/GSGrid_Variance.cpp:206 [error] - Common realloc mistake: "y_diff" nulled but not freed upon failure
• ./src/modules_simulation/hydrology/sim_hydrology/WaterRetentionCapacity.cpp:182 [error] - Memory leak: pCRA
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Geometry.h:17 [error] - Memory leak: AB
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Geometry.h:17 [error] - Memory leak: BC
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Geometry.h:30 [error] - Memory leak: AB
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Geometry.h:30 [error] - Memory leak: AC
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Polygon_Clipper.cpp:924 [error] - Possible null pointer dereference: v - otherwise it is redundant to check if v is null at line 925
• ./src/modules_terrain_analysis/terrain_analysis/ta_profiles/Polygon_Clipper.cpp:1897 [error] - Possible null pointer dereference: vtx - otherwise it is redundant to check if vtx is null at line 1900
• ./src/saga_core/saga_api/mat_regression.cpp:212 [error] - Passing value -1.0 to sqrt() leads to undefined result
• ./src/saga_core/saga_api/mat_regression.cpp:245 [error] - Passing value -1.0 to sqrt() leads to undefined result
• ./src/saga_core/saga_gui/wx/propgrid/editors.cpp:780 [error] - Null pointer dereference
• ./src/saga_core/saga_gui/wx/propgrid/editors.cpp:797 [error] - Null pointer dereference
• ./src/saga_core/saga_gui/wx/propgrid/propgrid.cpp:1738 [error] - Null pointer dereference
• ./src/saga_core/saga_gui/wx/propgrid/propgrid.cpp:8027 [error] - Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.

---