Automated Code Analysis

cppcheck analysis of scummvm_1.1.1-1.dsc

• ./backends/platform/ds/arm9/source/fat/gba_nds_fat.c:1077 [error] - Buffer access out-of-bounds: dir.name
• ./backends/platform/ds/arm9/source/fat/gba_nds_fat.c:3187 [error] - Buffer access out-of-bounds: dirEntry.name
• ./backends/platform/psp/psploader.cpp:372 [error] - Memory leak: shdr
• ./common/debug.cpp:160 [error] - Uninitialized variable: buf
• ./common/textconsole.cpp:107 [error] - Uninitialized variable: buf_output
• ./engines/agi/predictive.cpp:563 [error] - Dangerous usage of 'target' (strncpy doesn't always 0-terminate it)
• ./engines/gob/expression.cpp:490 [error] - Array index -3 is out of bounds
• ./engines/gob/expression.cpp:874 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:881 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:887 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:892 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:897 [error] - Array index -3 is out of bounds
• ./engines/gob/expression.cpp:897 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:902 [error] - Array index -3 is out of bounds
• ./engines/gob/expression.cpp:902 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:907 [error] - Array index -3 is out of bounds
• ./engines/gob/expression.cpp:907 [error] - Array index -1 is out of bounds
• ./engines/gob/expression.cpp:912 [error] - Array index -3 is out of bounds
• ./engines/gob/expression.cpp:912 [error] - Array index -1 is out of bounds
• ./engines/m4/converse.cpp:862 [error] - Buffer access out-of-bounds
• ./engines/scumm/imuse/imuse.cpp:819 [error] - Possible null pointer dereference: player - otherwise it is redundant to check if player is null at line 820
• ./engines/scumm/player_v2a.cpp:1917 [error] - Memory leak: snd
• ./engines/scumm/script_v5.cpp:1815 [error] - Possible null pointer dereference: ptr
• ./engines/scumm/script_v5.cpp:1813 [error] - Common realloc mistake: "ptr" nulled but not freed upon failure
• ./engines/tinsel/tinlib.cpp:1717 [error] - Uninitialized variable: myEscape
• ./engines/tinsel/tinlib.cpp:2032 [error] - Uninitialized variable: myEscape
• ./engines/tinsel/tinlib.cpp:3177 [error] - Uninitialized variable: x
• ./engines/tinsel/tinlib.cpp:3178 [error] - Uninitialized variable: y
• ./tools/create_kyradat/pak.cpp:145 [error] - Resource leak: file
• ./tools/create_kyradat/pak.cpp:171 [error] - Resource leak: file
• ./tools/create_kyradat/pak.cpp:205 [error] - Memory leak: data
• ./tools/create_msvc/create_msvc.cpp:1248 [error] - Resource leak: dirp
• ./tools/make-scumm-fontdata.c:843 [error] - Common realloc mistake: "specialCharsetData" nulled but not freed upon failure
• ./tools/md5table.c:297 [error] - Common realloc mistake: "entriesBuffer" nulled but not freed upon failure
• ./tools/sci/scipack.cpp:144 [error] - Resource leak: resource_000
• ./tools/sci/sciunpack.cpp:464 [error] - Dereferencing 'outf' after it is deallocated / released
• ./tools/sci/sciunpack.cpp:440 [error] - Resource leak: outf
• ./tools/skycpt/cptcompiler.cpp:556 [error] - Resource leak: dif

---