Automated Code Analysis

cppcheck analysis of slashem_0.0.7E7F3-2.dsc

• ./src/alloc.c:93 [error] - Return of the address of an auto-variable
• ./src/do_name.c:619 [error] - Returning pointer to local array variable
• ./src/do_name.c:652 [error] - Returning pointer to local array variable
• ./src/do_name.c:656 [error] - Returning pointer to local array variable
• ./src/do_name.c:661 [error] - Returning pointer to local array variable
• ./src/do_name.c:738 [error] - Returning pointer to local array variable
• ./src/do_name.c:743 [error] - Returning pointer to local array variable
• ./src/do_name.c:748 [error] - Returning pointer to local array variable
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'ALLEG_FX'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'AMIGA'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'GOLDOBJ'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'LINT'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'MAC'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'MAC_MPW'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'NO_SIGNAL'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'SYSV'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./src/end.c:329 [error] - Invalid number of character ({) when these macros are defined: 'WIZARD'.
• ./src/invent.c:1867 [error] - Returning pointer to local array variable
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'MAC;OVLB'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB;STEED'.
• ./src/pline.c:69 [error] - Invalid number of character ({) when these macros are defined: 'OVLB;WIZARD'.
• ./src/potion.c:2180 [error] - Possible null pointer dereference: obj - otherwise it is redundant to check if obj is null at line 2188
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMIFLUSH;AMII_GRAPHICS'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;CLIPPING'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;HACKFONT'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;INTUI_NEW_LOOK'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AMII_GRAPHICS;OPT_DISPMAP'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'AZTEC_C'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'CHDIR'.
• ./sys/amiga/amiwind.c:948 [error] - Invalid number of character ({) when these macros are defined: 'INTUI_NEW_LOOK;__SASC'.
• ./sys/amiga/winami.c:778 [error] - Invalid number of character ({) when these macros are defined: 'AMIGA_INTUITION;EXTMENU'.
• ./sys/atari/tos.c:275 [error] - Resource leak: fromfd
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/msdos/bmp2txt.c:137 [error] - No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MFLOPPY'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MFLOPPY;TOS'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MICRO'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MOVERLAY'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;NO_TERMS'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'OS2_CODEVIEW'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'TOS'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'TOS;__MINT__'.
• ./sys/share/pcsys.c:420 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./sys/share/pctty.c:89 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/pctty.c:89 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;NO_TERMS'.
• ./sys/share/pctty.c:89 [error] - Invalid number of character ({) when these macros are defined: 'MSDOS;PC_MOUSE'.
• ./sys/share/pctty.c:89 [error] - Invalid number of character ({) when these macros are defined: 'TIMED_DELAY;_MSC_VER'.
• ./sys/share/pctty.c:89 [error] - Invalid number of character ({) when these macros are defined: 'TOS'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'BSD;POSIX_TYPES'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'LINT'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'LINUX'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_JOB_CONTROL'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_JOB_CONTROL;VSUSP'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'POSIX_TYPES'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'TAB3'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'TCSETS'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'TEXTCOLOR;TTY_GRAPHICS;_M_UNIX'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'TEXTCOLOR;TTY_GRAPHICS;__linux__'.
• ./sys/share/unixtty.c:454 [error] - Invalid number of character ({) when these macros are defined: 'TTY_GRAPHICS'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'MAIL'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'SAVE_ON_FATAL_ERROR'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'TIMED_DELAY'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: 'USE_QIO_INPUT'.
• ./sys/vms/vmstty.c:491 [error] - Invalid number of character ({) when these macros are defined: '__GNUC__'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'APSTUDIO_INVOKED'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'APSTUDIO_INVOKED;APSTUDIO_READONLY_SYMBOLS'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'OVL0'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIN_CE_POCKETPC'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIN_CE_SMARTPHONE'.
• ./sys/wince/winhack.c:288 [error] - Invalid number of character ({) when these macros are defined: 'WIZARD'.
• ./sys/winnt/nttty.c:1043 [error] - Invalid number of character ({) when these macros are defined: 'WIN32CON'.
• ./sys/winnt/winnt.c:274 [error] - Invalid number of character ({) when these macros are defined: 'WIN32'.
• ./sys/winnt/winnt.c:274 [error] - Invalid number of character ({) when these macros are defined: 'WIN32;WIZARD'.
• ./sys/winnt/winnt.c:274 [error] - Invalid number of character ({) when these macros are defined: 'WIN32;__CYGWIN__'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'ALLOCA_HACK'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'AZTEC'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'SYSV'.
• ./util/panic.c:46 [error] - Invalid number of character ({) when these macros are defined: 'VMS'.
• ./util/recover.c:287 [error] - Resource leak: lfd
• ./win/X11/winmesg.c:601 [error] - Uninitialized variable: wp
• ./win/gtk/cc-gtk.c:244 [error] - Common realloc mistake: "config" nulled but not freed upon failure
• ./win/gtk/gtk.c:1434 [error] - Memory leak: rc_file
• ./win/gtk/gtk.c:3045 [error] - Mismatching allocation and deallocation: md5sum
• ./win/gtk/gtk.c:3060 [error] - Mismatching allocation and deallocation: md5sum
• ./win/gtk/gtk.c:3064 [error] - Mismatching allocation and deallocation: md5sum
• ./win/gtk/panic.c:57 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./win/gtk/panic.c:57 [error] - Invalid number of character ({) when these macros are defined: 'AZTEC'.
• ./win/gtk/panic.c:57 [error] - Invalid number of character ({) when these macros are defined: 'SYSV'.
• ./win/gtk/panic.c:57 [error] - Invalid number of character ({) when these macros are defined: 'VMS'.
• ./win/proxy/mapid.c:45 [error] - Common realloc mistake: "mapid__windows" nulled but not freed upon failure
• ./win/share/txtfilt.c:159 [error] - Common realloc mistake: "match_p" nulled but not freed upon failure
• ./win/share/txtfilt.c:174 [error] - Common realloc mistake: "match_p" nulled but not freed upon failure
• ./win/share/txtfilt.c:143 [error] - Resource leak: fp
• ./win/share/txtmerge.c:64 [error] - Common realloc mistake: "tiles" nulled but not freed upon failure
• ./win/win32/mhsplash.c:121 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./win/win32/mhsplash.c:152 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./win/win32/nhprocs.c:678 [error] - Null pointer dereference

---