Automated Code Analysis

cppcheck analysis of squid3_3.1.6-1.2.dsc

• ./helpers/basic_auth/MSNT/confload.c:96 [error] - Resource leak: ConfigFile
• ./helpers/basic_auth/MSNT/rfcnb-io.c:69 [error] - Uninitialized variable: x
• ./helpers/basic_auth/squid_radius_auth/squid_rad_auth.c:268 [error] - Resource leak: cf
• ./helpers/external_acl/mswin_ad_group/mswin_check_ad_group.c:263 [error] - Dangerous usage of 'NTDomain' (strncpy doesn't always 0-terminate it)
• ./helpers/external_acl/mswin_lm_group/win32_check_group.c:345 [error] - Dangerous usage of 'NTDomain' (strncpy doesn't always 0-terminate it)
• ./helpers/external_acl/unix_group/check_group.c:160 [error] - Common realloc mistake: "grents" nulled but not freed upon failure
• ./snmplib/parse.c:1082 [error] - Resource leak: fp
• ./src/comm.cc:2398 [error] - Uninitialized variable: buf
• ./src/icp_v2.cc:217 [error] - Possible null pointer dereference: q - otherwise it is redundant to check if q is null at line 221
• ./src/icp_v2.cc:219 [error] - Possible null pointer dereference: q - otherwise it is redundant to check if q is null at line 221
• ./src/icp_v2.cc:220 [error] - Possible null pointer dereference: q - otherwise it is redundant to check if q is null at line 221
• ./src/recv-announce.cc:102 [error] - Buffer overrun possible for long cmd-line args
• ./test-suite/splay.cc:148 [error] - Possible null pointer dereference: top
• ./test-suite/splay.cc:171 [error] - Possible null pointer dereference: safeTop
• ./test-suite/splay.cc:189 [error] - Possible null pointer dereference: safeTop
• ./test-suite/tcp-banger2.c:537 [error] - Common realloc mistake: "custom_header" nulled but not freed upon failure
• ./test-suite/tcp-banger2.c:442 [error] - Resource leak: f

---