Automated Code Analysis

cppcheck analysis of torque_2.4.8+dfsg-9.dsc

• ./doc/soelim.c:222 [error] - Resource leak: newin
• ./src/cmds/pbspoe.c:198 [error] - Resource leak: old
• ./src/cmds/qchkpt.c:38 [error] - Buffer overrun possible for long cmd-line args
• ./src/cmds/qmove.c:117 [error] - Buffer overrun possible for long cmd-line args
• ./src/cmds/qorder.c:119 [error] - Buffer overrun possible for long cmd-line args
• ./src/cmds/qsub.c:1787 [error] - Common realloc mistake: "job_env" nulled but not freed upon failure
• ./src/cmds/qsub.c:1703 [error] - Common realloc mistake: "job_env" nulled but not freed upon failure
• ./src/cmds/qsub.c:1736 [error] - Common realloc mistake: "job_env" nulled but not freed upon failure
• ./src/cmds/qsub.c:838 [error] - Mismatching allocation and deallocation: filter_pipe
• ./src/cmds/qsub.c:2499 [error] - Memory leak: socks
• ./src/cmds/qsub.c:4241 [error] - Resource leak: tmpfd
• ./src/cmds/qsub.c:4353 [error] - Resource leak: config_stream
• ./src/drmaa/src/submit.c:502 [error] - Common realloc mistake: "env" nulled but not freed upon failure
• ./src/drmaa/src/submit.c:199 [error] - Memory leak: job
• ./src/drmaa/src/submit.c:421 [error] - Deallocating a deallocated pointer: script
• ./src/gui/Ccode/xpbs_scriptload.c:940 [error] - Memory leak: pdepend
• ./src/lib/Libattr/attr_fn_arst.c:189 [error] - Memory leak: pbuf
• ./src/lib/Libifl/rpp.c:2537 [error] - Common realloc mistake: "rpp_fd_array" nulled but not freed upon failure
• ./src/lib/Libnet/net_server.c:513 [error] - Dereferencing 'i' after it is deallocated / released
• ./src/lib/Libnet/port_forwarding.c:364 [error] - Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it)
• ./src/pam/pam_pbssimpleauth.c:121 [error] - Resource leak: jobdir
• ./src/pam/pam_pbssimpleauth.c:112 [error] - Resource leak: jobdir
• ./src/resmom/digitalunix/mom_mach.c:1548 [error] - Memory leak: jids
• ./src/resmom/digitalunix/mom_mach.c:1739 [error] - Memory leak: uids
• ./src/resmom/fujitsu/mom_mach.c:1582 [error] - Memory leak: jids
• ./src/resmom/fujitsu/mom_mach.c:1773 [error] - Memory leak: uids
• ./src/resmom/hpux10/mom_mach.c:752 [error] - Common realloc mistake: "proc_status" nulled but not freed upon failure
• ./src/resmom/hpux10/mom_mach.c:1453 [error] - Memory leak: jids
• ./src/resmom/hpux10/mom_mach.c:1646 [error] - Memory leak: uids
• ./src/resmom/hpux11/mom_mach.c:799 [error] - Common realloc mistake: "proc_status" nulled but not freed upon failure
• ./src/resmom/hpux11/mom_mach.c:1533 [error] - Memory leak: jids
• ./src/resmom/hpux11/mom_mach.c:1726 [error] - Memory leak: uids
• ./src/resmom/irix6array/mom_mach.c:1171 [error] - Resource leak: fd
• ./src/resmom/linux/mom_mach.c:462 [error] - Resource leak: fp
• ./src/resmom/linux/mom_mach.c:1745 [error] - Memory leak: hold
• ./src/resmom/mom_comm.c:922 [error] - Memory leak: ep
• ./src/resmom/mom_comm.c:5717 [error] - Memory leak: ep
• ./src/resmom/mom_inter.c:552 [error] - Memory leak: socks
• ./src/resmom/mom_main.c:948 [error] - Common realloc mistake: "list" nulled but not freed upon failure
• ./src/resmom/mom_main.c:1058 [error] - Common realloc mistake: "list" nulled but not freed upon failure
• ./src/resmom/pbs_demux.c:359 [error] - Memory leak: routem
• ./src/resmom/requests.c:641 [error] - Resource leak: fds
• ./src/resmom/solaris5/mom_mach.c:1550 [error] - Memory leak: jids
• ./src/resmom/solaris5/mom_mach.c:1741 [error] - Memory leak: uids
• ./src/resmom/solaris7/mom_mach.c:1645 [error] - Memory leak: jids
• ./src/resmom/solaris7/mom_mach.c:1836 [error] - Memory leak: uids
• ./src/resmom/start_exec.c:2545 [error] - fflush() called on input stream "stdin" may result in undefined behaviour
• ./src/resmom/start_exec.c:6035 [error] - Dangerous usage of 'tmpLine' (strncpy doesn't always 0-terminate it)
• ./src/resmom/unicos8/mom_mach.c:1121 [error] - Invalid number of character ({) when these macros are defined: ''.
• ./src/resmom/unicos8/mom_mach.c:1121 [error] - Invalid number of character ({) when these macros are defined: 'SRFS'.
• ./src/resmom/unicos8/mom_mach.c:1121 [error] - Invalid number of character ({) when these macros are defined: 'max'.
• ./src/scheduler.cc/samples/cray_t3e/pnp.c:264 [error] - Resource leak: fd
• ./src/scheduler.cc/samples/cray_t3e/usersort.c:732 [error] - Common realloc mistake: "Users" nulled but not freed upon failure
• ./src/scheduler.cc/samples/dec_cluster/schedinit.c:362 [error] - Possible null pointer dereference: aptr - otherwise it is redundant to check if aptr is null at line 364
• ./src/scheduler.cc/samples/dec_cluster/toolkit.c:1591 [error] - Resource leak: fd
• ./src/scheduler.cc/samples/dec_cluster/usersort.c:677 [error] - Common realloc mistake: "Users" nulled but not freed upon failure
• ./src/scheduler.cc/samples/fifo/fairshare.c:319 [error] - Resource leak: fp
• ./src/scheduler.cc/samples/fifo/fairshare.c:364 [error] - Memory leak: unknown
• ./src/scheduler.cc/samples/fifo/job_info.c:790 [error] - Common realloc mistake: "new_jobs" nulled but not freed upon failure
• ./src/scheduler.cc/samples/fifo/node_info.c:545 [error] - Common realloc mistake: "new_nodes" nulled but not freed upon failure
• ./src/scheduler.cc/samples/msic_cluster/toolkit.c:1598 [error] - Resource leak: fd
• ./src/scheduler.cc/samples/msic_cluster/usersort.c:586 [error] - Common realloc mistake: "Users" nulled but not freed upon failure
• ./src/scheduler.cc/samples/sgi_origin/pnp.c:270 [error] - Resource leak: fd
• ./src/scheduler.cc/samples/sgi_origin/usersort.c:815 [error] - Common realloc mistake: "Users" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/qschedule.c:658 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/qschedule.c:681 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/toolkit.c:1601 [error] - Resource leak: fd
• ./src/scheduler.cc/samples/umn_cluster/usersort.c:461 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/usersort.c:483 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/usersort.c:597 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.cc/samples/umn_cluster/usersort.c:619 [error] - Common realloc mistake: "JobSchedule" nulled but not freed upon failure
• ./src/scheduler.tcl/pbs_sched.c:406 [error] - Common realloc mistake: "body" nulled but not freed upon failure
• ./src/server/pbsd_init.c:1319 [error] - Resource leak: dir
• ./src/server/pbsd_init.c:1268 [error] - Resource leak: fd
• ./src/server/pbsd_init.c:2200 [error] - Resource leak: dir
• ./src/server/pbsd_init.c:2079 [error] - fflush() called on input stream "stdin" may result in undefined behaviour
• ./src/server/pbsd_init.c:1277 [error] - Resource leak: fd
• ./src/server/pbsd_main.c:2344 [error] - Resource leak: fds
• ./src/server/req_manager.c:1912 [error] - Memory leak: nodename
• ./src/server/req_register.c:1453 [error] - Memory leak: pdj
• ./src/server/req_register.c:1499 [error] - Memory leak: pdep
• ./src/server/req_register.c:1514 [error] - Memory leak: pdj
• ./src/server/req_register.c:2003 [error] - Memory leak: pnwdj
• ./src/server/svr_resccost.c:227 [error] - Memory leak: pcost
• ./src/server/svr_resccost.c:354 [error] - Memory leak: pcold
• ./src/tools/tracejob.c:886 [error] - Common realloc mistake: "log_lines" nulled but not freed upon failure

---