Automated Code Analysis

cppcheck analysis of wesnoth-1.8_1.8.5-1.dsc

• ./src/config.hpp:279 [error] - Return of the address of an auto-variable
• ./src/tstring.hpp:149 [error] - Returning reference to temporary
• ./src/tstring.hpp:152 [error] - Returning reference to temporary
• ./src/tstring.hpp:150 [error] - Returning pointer to temporary
• ./src/shared_string.hpp:26 [error] - Returning pointer to temporary
• ./src/addon_checks.cpp:148 [style] - The iterator incrementing is suspicious - it is incremented at line 148 and then at line 146 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/tstring.hpp:89 [error] - Returning pointer to temporary
• ./src/formatter.hpp:52 [error] - Returning pointer to temporary
• ./src/editor/editor_controller.cpp:348 [error] - instance of "map_context_refresher" object destroyed immediately
• ./src/generate_report.cpp:161 [style] - The iterator incrementing is suspicious - it is incremented at line 161 and then at line 157 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/generate_report.cpp:352 [style] - The iterator incrementing is suspicious - it is incremented at line 352 and then at line 349 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/help.cpp:1503 [style] - The iterator incrementing is suspicious - it is incremented at line 1503 and then at line 1493 The loop might unintentionally skip an element in the container. There is no comparison between these increments to prevent that the iterator is incremented beyond the end.
• ./src/poolalloc.c:451 [error] - Common realloc mistake: "items" nulled but not freed upon failure
• ./src/terrain_filter.cpp:416 [error] - Iterator 'intersect_itor' becomes invalid when deleted by value from 'xy_set'
• ./utils/wesnoth-attack-sim.c:438 [error] - Memory leak: res_def

---