Automated Code Analysis

cppcheck analysis of wireshark_1.2.11-4.dsc

• ./epan/crypt/airpdcap.c:1876 [error] - Memory leak: ssid
• ./epan/crypt/crypt-sha1.c:433 [error] - Resource leak: f
• ./epan/diam_dict.c:1534 [error] - Possible null pointer dereference: e
• ./epan/dissectors/packet-amqp.c:1069 [style] - Redundant assignment of "typename" in switch
• ./epan/dissectors/packet-amqp.c:1070 [style] - Redundant assignment of "value" in switch
• ./epan/dissectors/packet-gsm_sms.c:2407 [style] - Redundant assignment of "str" in switch
• ./epan/dissectors/packet-gsm_sms.c:2407 [style] - Redundant assignment of "iei_fcn" in switch
• ./epan/dissectors/packet-multipart.c:802 [error] - Memory leak: filename
• ./epan/dissectors/packet-multipart.c:802 [error] - Memory leak: typename
• ./epan/dissectors/packet-ncp2222.inc:11257 [style] - Redundant assignment of "resolve_eid" in switch
• ./epan/dissectors/packet-rsvp.c:3429 [style] - Redundant assignment of "dlci_len" in switch
• ./epan/dissectors/packet-sdp.c:1546 [error] - Memory leak: key
• ./epan/dissectors/packet-smb.c:8743 [error] - Possible null pointer dereference: nti - otherwise it is redundant to check if nti is null at line 8762
• ./epan/dissectors/packet-smb.c:8749 [error] - Possible null pointer dereference: nti - otherwise it is redundant to check if nti is null at line 8762
• ./epan/dissectors/packet-ssh.c:413 [error] - Possible null pointer dereference: title - otherwise it is redundant to check if title is null at line 415
• ./epan/emem.c:976 [error] - Possible null pointer dereference: node
• ./epan/filesystem.c:959 [error] - Memory leak: homedir
• ./epan/prefs.c:647 [error] - Memory leak: preference
• ./epan/prefs.c:664 [error] - Memory leak: preference
• ./epan/prefs.c:693 [error] - Memory leak: preference
• ./epan/prefs.c:722 [error] - Memory leak: preference
• ./epan/prefs.c:749 [error] - Memory leak: preference
• ./epan/radius_dict.c:2820 [error] - Memory leak: s
• ./epan/sigcomp-udvm.c:2259 [style] - Redundant assignment of "operand_address" in switch
• ./epan/sigcomp-udvm.c:2368 [style] - Redundant assignment of "operand_address" in switch
• ./epan/sigcomp-udvm.c:2378 [style] - Redundant assignment of "operand_address" in switch
• ./epan/sigcomp-udvm.c:2473 [style] - Redundant assignment of "operand_address" in switch
• ./epan/sigcomp-udvm.c:2602 [style] - Redundant assignment of "operand_address" in switch
• ./epan/stats_tree.c:644 [error] - Memory leak: range_node
• ./epan/stats_tree.c:677 [error] - Memory leak: range_node
• ./epan/tcap-persistentdata.c:1212 [error] - Memory leak: p_tcaphash_begincall
• ./epan/tcap-persistentdata.c:1752 [error] - Memory leak: p_tcaphash_ansicall
• ./epan/wslua/wslua_gui.c:293 [error] - Possible null pointer dereference: pd - otherwise it is redundant to check if pd is null at line 296
• ./epan/wslua/wslua_pinfo.c:665 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:666 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:667 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:668 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:669 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:670 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:835 [error] - Memory leak: addr
• ./epan/wslua/wslua_pinfo.c:855 [error] - Memory leak: addr
• ./epan/wslua/wslua_proto.c:603 [error] - Memory leak: f
• ./epan/wslua/wslua_proto.c:1389 [error] - Memory leak: name
• ./epan/wslua/wslua_proto.c:1389 [error] - Memory leak: ui_name
• ./epan/wslua/wslua_tvb.c:822 [error] - Memory leak: addr
• ./gtk/hostlist_table.c:723 [error] - Memory leak: map_data_filename
• ./gtk/recent.c:670 [error] - Memory leak: cfmt
• ./gtk/sctp_assoc_analyse.c:127 [error] - Memory leak: assinfo
• ./gtk/sctp_assoc_analyse.c:154 [error] - Memory leak: assinfo
• ./gtk/sctp_assoc_analyse.c:165 [error] - Memory leak: assinfo
• ./gtk/sctp_stat.c:656 [error] - Memory leak: info
• ./packaging/u3/win32/u3util.c:393 [error] - Dangerous usage of 'dir_spec' (strncpy doesn't always 0-terminate it)
• ./packaging/u3/win32/u3util.c:568 [error] - Dangerous usage of 'wireshark_path' (strncpy doesn't always 0-terminate it)
• ./plugins/wimaxasncp/wimaxasncp_dict.c:1471 [error] - Possible null pointer dereference: e
• ./plugins/wimaxasncp/wimaxasncp_dict.c:3087 [error] - Memory leak: d
• ./randpkt.c:723 [error] - Resource leak: fd
• ./tap-iostat.c:729 [error] - Memory leak: io
• ./tools/lemon/lemon.c:1405 [error] - Buffer access out-of-bounds
• ./tools/lemon/lemon.c:1411 [error] - Buffer access out-of-bounds
• ./tools/lemon/lemon.c:1426 [error] - Common realloc mistake: "azDefine" nulled but not freed upon failure
• ./tools/lemon/lemon.c:3295 [error] - Common realloc mistake: "z" nulled but not freed upon failure
• ./tools/lemon/lemon.c:2369 [error] - Memory leak: sp
• ./tools/lemon/lemon.c:2583 [error] - Resource leak: fp
• ./tshark.c:1654 [error] - Memory leak: cf_name

---