Automated Code Analysis

cppcheck analysis of wwwoffle_2.9f-2.2.dsc

• ./src/certificates.c:349 [error] - Common realloc mistake: "trusted_x509_crts" nulled but not freed upon failure
• ./src/certificates.c:447 [error] - Common realloc mistake: "trusted_x509_crts" nulled but not freed upon failure
• ./src/certificates.c:296 [error] - Resource leak: pwdhandle
• ./src/certificates.c:642 [error] - Memory leak: filename
• ./src/certificates.c:612 [error] - Resource leak: pwdhandle
• ./src/certinfo.c:563 [error] - Common realloc mistake: "dn" nulled but not freed upon failure
• ./src/certinfo.c:577 [error] - Common realloc mistake: "issuer_dn" nulled but not freed upon failure
• ./src/configmisc.c:561 [error] - Common realloc mistake: "string" nulled but not freed upon failure
• ./src/configmisc.c:570 [error] - Common realloc mistake: "string" nulled but not freed upon failure
• ./src/configmisc.c:579 [error] - Common realloc mistake: "string" nulled but not freed upon failure
• ./src/configmisc.c:585 [error] - Common realloc mistake: "string" nulled but not freed upon failure
• ./src/errors.c:458 [error] - Common realloc mistake: "string" nulled but not freed upon failure
• ./src/ftp.c:240 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 242
• ./src/ftp.c:275 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 277
• ./src/ftp.c:324 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 326
• ./src/ftp.c:381 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 383
• ./src/ftp.c:418 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 420
• ./src/ftp.c:474 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 476
• ./src/ftp.c:513 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 515
• ./src/ftp.c:540 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 542
• ./src/ftp.c:587 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 589
• ./src/ftp.c:646 [error] - Possible null pointer dereference: str - otherwise it is redundant to check if str is null at line 648
• ./src/miscencdec.c:935 [error] - Common realloc mistake: "ret" nulled but not freed upon failure
• ./src/spool.c:327 [error] - Common realloc mistake: "req" nulled but not freed upon failure
• ./src/spool.c:1623 [error] - Resource leak: ufd
• ./src/wwwoffle-tools.c:1338 [error] - Resource leak: ufd
• ./src/wwwoffle.c:821 [error] - Common realloc mistake: "data" nulled but not freed upon failure

---