Automated Code Analysis

cppcheck analysis of xastir_1.9.4-3.1.dsc

• ./src/draw_symbols.c:158 [error] - Possible null pointer dereference: xfs_ptr - otherwise it is redundant to check if xfs_ptr is null at line 161
• ./src/main.c:3912 [error] - Resource leak: f
• ./src/main.c:3908 [error] - Resource leak: f_temp
• ./src/map_WMS.c:622 [error] - Possible null pointer dereference: image_info - otherwise it is redundant to check if image_info is null at line 636
• ./src/map_WMS.c:669 [error] - Possible null pointer dereference: image - otherwise it is redundant to check if image is null at line 671
• ./src/map_geo.c:1308 [error] - Possible null pointer dereference: image_info - otherwise it is redundant to check if image_info is null at line 1321
• ./src/map_geo.c:1311 [error] - Possible null pointer dereference: image_info - otherwise it is redundant to check if image_info is null at line 1321
• ./src/map_geo.c:1352 [error] - Possible null pointer dereference: image - otherwise it is redundant to check if image is null at line 1357
• ./src/map_geo.c:1353 [error] - Possible null pointer dereference: image - otherwise it is redundant to check if image is null at line 1357
• ./src/map_tiger.c:566 [error] - Possible null pointer dereference: image_info - otherwise it is redundant to check if image_info is null at line 581
• ./src/map_tiger.c:614 [error] - Possible null pointer dereference: image - otherwise it is redundant to check if image is null at line 616
• ./src/maps.c:8392 [error] - Possible null pointer dereference: temp - otherwise it is redundant to check if temp is null at line 8424
• ./src/maps.c:8409 [error] - Possible null pointer dereference: temp - otherwise it is redundant to check if temp is null at line 8424
• ./src/maps.c:8410 [error] - Possible null pointer dereference: temp - otherwise it is redundant to check if temp is null at line 8424
• ./src/maps.c:8411 [error] - Possible null pointer dereference: temp - otherwise it is redundant to check if temp is null at line 8424
• ./src/maps.c:8412 [error] - Possible null pointer dereference: temp - otherwise it is redundant to check if temp is null at line 8424
• ./src/maps.c:5329 [error] - Resource leak: f
• ./src/maps.c:5328 [error] - Resource leak: f
• ./src/objects.c:10868 [error] - Resource leak: f
• ./src/objects.c:10864 [error] - Resource leak: f_temp
• ./src/rotated.c:929 [error] - Memory leak: item
• ./src/rotated.c:1590 [error] - Memory leak: xp_in
• ./src/rotated.c:992 [error] - Memory leak: item.corners_x
• ./src/rotated.c:1003 [error] - Memory leak: item.corners_y
• ./src/shapelib/contrib/dbfinfo.c:116 [error] - Buffer access out-of-bounds: ftype
• ./src/shapelib/contrib/dbfinfo.c:129 [error] - Memory leak: panWidth
• ./src/shapelib/contrib/shpgeo.c:858 [style] - Redundant assignment of "dimension" in switch
• ./src/shapelib/dbfdump.c:293 [error] - Memory leak: panWidth
• ./src/shapelib/dbfopen.c:571 [error] - Memory leak: pszFullname
• ./src/shapelib/shpadd.c:168 [error] - Common realloc mistake: "padfX" nulled but not freed upon failure
• ./src/shapelib/shpadd.c:169 [error] - Common realloc mistake: "padfY" nulled but not freed upon failure
• ./src/shapelib/shpopen.c:484 [error] - Memory leak: pabyBuf
• ./src/shapelib/shpopen.c:683 [error] - Memory leak: pszBasename
• ./src/shapelib/shpopen.c:683 [error] - Memory leak: pszFullname
• ./src/shapelib/shpopen.c:688 [error] - Resource leak: fpSHP
• ./src/shapelib/shputils.c:195 [error] - Buffer overrun possible for long cmd-line args

---