Automated Code Analysis

cppcheck analysis of xscreensaver_5.11-1.dsc

• ./driver/demo-Gtk.c:3267 [error] - Possible null pointer dereference: hack - otherwise it is redundant to check if hack is null at line 3271
• ./driver/demo-Gtk.c:3268 [error] - Possible null pointer dereference: hack - otherwise it is redundant to check if hack is null at line 3271
• ./driver/demo-Gtk.c:523 [error] - Memory leak: msg
• ./driver/demo-Gtk.c:4385 [error] - Uninitialized variable: lhost
• ./driver/demo-Xm.c:1572 [error] - Uninitialized variable: lhost
• ./driver/demo-Xm.c:1570 [error] - Uninitialized variable: lhost
• ./driver/passwd-kerberos.c:217 [error] - Resource leak: fh
• ./driver/prefs.c:419 [error] - Common realloc mistake: "buf" nulled but not freed upon failure
• ./driver/splash.c:716 [error] - Possible null pointer dereference: sp - otherwise it is redundant to check if sp is null at line 718
• ./driver/subprocs.c:1171 [error] - Memory leak: nssw
• ./driver/test-mlstring.c:72 [error] - Common realloc mistake: "cstr" nulled but not freed upon failure
• ./driver/vms-getpwnam.c:97 [error] - Memory leak: entry
• ./driver/xdpyinfo.c:538 [error] - Possible null pointer dereference: depths
• ./driver/xscreensaver.c:1460 [error] - Resource leak: fd0
• ./driver/xscreensaver.c:1460 [error] - Resource leak: fd1
• ./driver/xscreensaver.c:1460 [error] - Resource leak: fd2
• ./hacks/asm6502.c:1714 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./hacks/asm6502.c:1722 [error] - Common realloc mistake: "buffer" nulled but not freed upon failure
• ./hacks/asm6502.c:1398 [error] - Memory leak: dec
• ./hacks/flag.c:299 [error] - Resource leak: f
• ./hacks/flag.c:299 [error] - Memory leak: pbv
• ./hacks/flag.c:299 [error] - Memory leak: pn
• ./hacks/flag.c:299 [error] - Memory leak: puvv
• ./hacks/glx/engine.c:284 [error] - Buffer access out-of-bounds: e.sin_table
• ./hacks/glx/engine.c:287 [error] - Buffer access out-of-bounds: e.cos_table
• ./hacks/glx/engine.c:290 [error] - Buffer access out-of-bounds: e.tan_table
• ./hacks/glx/flurry-spark.c:278 [error] - ### Internal error in Cppcheck. Please report it.
• ./hacks/glx/glhanoi.c:736 [error] - Memory leak: cosCache
• ./hacks/glx/glhanoi.c:736 [error] - Memory leak: sinCache
• ./hacks/glx/glschool_alg.c:174 [error] - Memory leak: s.theFish
• ./hacks/glx/gltext.c:204 [error] - Mismatching allocation and deallocation: p
• ./hacks/glx/jigglypuff.c:460 [error] - Memory leak: hn2
• ./hacks/glx/jigglypuff.c:504 [error] - Memory leak: hn1
• ./hacks/glx/jigglypuff.c:504 [error] - Memory leak: hn2
• ./hacks/glx/jigglypuff.c:540 [error] - Memory leak: vtx
• ./hacks/glx/sonar-icmp.c:1181 [error] - Possible null pointer dereference: pd - otherwise it is redundant to check if pd is null at line 1186
• ./hacks/juggle.c:2561 [error] - instance of "wander" object destroyed immediately
• ./hacks/kumppa.c:281 [error] - Memory leak: chks
• ./hacks/polyominoes.c:1505 [error] - Buffer access out-of-bounds: pentomino
• ./hacks/screenhack.c:419 [error] - Resource leak: fd0
• ./hacks/screenhack.c:419 [error] - Resource leak: fd1
• ./hacks/screenhack.c:419 [error] - Resource leak: fd2
• ./hacks/xpm-pixmap.c:329 [error] - Possible null pointer dereference: ximage - otherwise it is redundant to check if ximage is null at line 330
• ./hacks/xsublim.c:529 [error] - Memory leak: exe_Command
• ./hacks/xsublim.c:528 [error] - Mismatching allocation and deallocation: exe_Fs
• ./utils/colors.c:692 [error] - Memory leak: colors2
• ./utils/grabclient.c:257 [error] - Memory leak: ndpy
• ./utils/minixpm.c:191 [error] - Memory leak: pixels

---