Git log: commit 7e2ebb46a532dc5640b52a9d8832faf845840164
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 18:48:47 2021 +0300
really remove the patch
commit 738092545de5a47f4d56d2bf080d4aea4a4804cc
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 18:36:37 2021 +0300
releasing package 389-ds-base version 1.4.4.17-1
commit 7835b2b71d9bee5defba31e5f10a4ea248ad90ac
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 18:29:06 2021 +0300
CVE-2017-15135.patch: Dropped, fixed by upstream issue #4817.
commit 28a9ab4410386d483e9560196b2c6dac3fc71654
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 18:36:07 2021 +0300
close a bug
commit 93fc088ca87e524136f774419744f3655fe3661c
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 17:53:42 2021 +0300
bump the version
commit e60cb8560348f2e5885928dbc1bcfced296d9e97
Merge: ae9fc0ac5 5e1e392ae
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 17:53:19 2021 +0300
Merge branch 'upstream'
commit ae9fc0ac58e878ce8bbaf6ba1cfb9925ce9ab73e
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Mon Oct 18 17:48:33 2021 +0300
Add a dependency to libjemalloc2, and add a symlink to it so the preload works. (Closes: #992696)
commit 5e1e392ae8aca76f5325987197e35fbeddfc58a7
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Mon Sep 20 17:01:33 2021 -0400
Bump version to 1.4.4.17
commit 8127b3d05af242f06ba5833b001f25f56e215a31
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Mon Sep 20 10:38:49 2021 -0400
Issue 4927 - rebase lib389 and cockpit in 1.4.4
Description: 389-ds-base-1.4.4 has somehow become out of sync
with critical fixes in lib389 and cockpit. It is
too difficult to try and find which patches are
missing. Instead we can just rebase the source
code for lib389 and cockpit from branch 389-ds-base-2.0.
fixes: https://github.com/389ds/389-ds-base/issues/4927
Reviewed by: spichugi & jchapman(Thanks!!)
commit ebacadde453116784ab47231d070178c6d05ce82
Author: Marc Muehlfeld <mmuehlfeld@redhat.com>
Date: Tue Aug 24 16:33:41 2021 +0200
Issue 4908 - Updated several dsconf --help entries (typos, wrong descriptions, etc.)
Description:
The --help of dsconf and its subcommands contain several incorrect descriptions, typos, inconsistent language, some entries end with a ".", some doesn't, some descriptions start with lowercase, ...
For a better user experience, the descriptions of subcommands, and parameters should be reviewed and improved.
Fixes: #4908
Reviewed by: Mark Reynolds, William Brown, and Simon Pichugin
commit f6bb281dea0f17d98ec2c27038bd8f8072db6d97
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Mon Sep 13 12:18:35 2021 -0400
Issue 4912 - Account Policy plugin does not set the config entry DN
Description: Although we create the config entry for the Account Policy
plugin, we do not list the config entry DN in the main plugin entry
via nsslapd-pluginarg0
relates: https://github.com/389ds/389-ds-base/issues/4912
Reviewed by: mreynolds(one line commit rule)
commit ef01f6d8311fd82ff61944cb2f26057a2d131a92
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Sat Sep 11 10:28:47 2021 -0400
Issue 4796 - Add support for nsslapd-state to CLI & UI
Description:
Add support for nsslapd-state to lib389 and UI. Also added a check to prevent the changing of nsslapd-state for replicated suffixes.
Also did a little UI cleanup where a bottom margin was added to the bottom of pages instead of using "hr" to create the gap.
relates: https://github.com/389ds/389-ds-base/issues/4796
Reviewed by: jchapman & spichugi(Thanks!)
commit 012a6a35d05a056e028d6d4e9e792aab3a697d7c
Author: Simon Pichugin <spichugi@redhat.com>
Date: Fri Sep 10 14:17:41 2021 -0700
Issue 4894 - IPA failure in ipa user-del --preserve (#4907)
Bug Description: Starting with 389-ds 2.0.8 on rawhide,
any call to ipa user-del --preserve fails with
This entry already exists.
Fix Description: We should split 'dn' parameter in searchAllSubtrees
into parent and target. As one of them is used for excluding the
subtree checks and another one for searching.
Improve 'superior' processing when we don't change the parent.
Rename variables in a more sane way.
Fixes: https://github.com/389ds/389-ds-base/issues/4894
Reviewed by: @Firstyear, @tbordaz, @progier389 (Thanks!)
commit 3982ce6957dee8547d0853ca0d52834d1935ea88
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Fri Sep 10 09:39:57 2021 -0400
Issue 4169 - backport lib389 cert list fix
Description: We didn't call ensure_str() on the output from certutil
commands
relates: https://github.com/389ds/389-ds-base/issues/4169
Reviewed by: mreynolds(one line commit rule)
commit 7eed56019f4071b5b34a9f88104cb6e6f50cef88
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Wed Sep 8 15:48:25 2021 -0400
Issue 4912 - dsidm command crashing when account policy plugin is enabled
Bug Description: If the account policy plugin is enabled, but not
configured then dsidm will crash when checking an
entry's status.
Fix Description: Check if the config DN is present before trying
to check its values.
relates: https://github.com/389ds/389-ds-base/issues/4912
Reviewed by: firstyear(thanks!)
commit 97f8433825a01860f1f9875556e349975de84846
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Wed Sep 8 10:31:19 2021 -0400
Issue 4910 - db reindex corrupts RUV tombstone nsuiqueid index
Bug Description: During a reindex task we skip the RUV tombstone entry,
which corrupts the nsuniqueid index.
Fix Description: Make sure we still index nsuniqueid index for
the RUV tombstone entry.
relates: https://github.com/389ds/389-ds-base/issues/4910
Reviewed by: firstyear & progier389 (Thanks!!)
commit 20de34288702f67b57d4c2f658f0b9ed2ae442f2
Author: Timo Aaltonen <tjaalton@debian.org>
Date: Tue Sep 7 15:39:40 2021 +0300
tests: Add isolation-container to restrictions.
commit 03a6752085d1c38e273a6af5b08a1df8909a484c
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Thu Sep 2 19:12:19 2021 -0400
Issue 4869 - Fix retro cl trimming misuse of monotonic/realtime clocks
Bug Description: Monotonic clocks were used to check if an entry was old
enough to be trimmed, but the real system time should be
used. So entries were never trimmed from the changelog.
Fix Description: Make sure monotonic clocks are only used for the
trimming interval, and real time clocks are used
for entry age.
relates: https://github.com/389ds/389-ds-base/issues/4869
Reviewed by: firstyear(Thanks!)
commit 0491c2175c116390d7770bf7b6c667e2f1b93ade
Author: James Chapman <jachapma@redhat.com>
Date: Thu Jul 29 14:27:09 2021 +0100
Issue - 4696 - Password hash upgrade on bind (#4840)
Description:
There is an unintended side effect of the "upgrade password
on bind" feature. It causes the password policy code to be
engaged and it resets the passwordExpirationtime in the entry.
Fix description:
Only allow an external password modify operation or an extended
password modify operation update the password info.
Relates: https://github.com/389ds/389-ds-base/issues/4696
Reviewed by: @droideck, @tbordaz, @mreynolds389 (Thank you)
commit a91c1f584d51d4ddbf30a9b973779193dd13345b
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Wed Aug 25 15:41:15 2021 -0400
Issue 4875 - CLI - Add some verbosity to installer
Description: Previously the installer would basically say
"Starting" and "Finished". If a step would
run into a problem it is difficult to narrow
down what is going wrong. So add a little more
output during the installation.
relates: https://github.com/389ds/389-ds-base/issues/4875
Reviewed by: firstyear & spichugi(Thanks!!)
commit 38e1e2618732235857a93b6c2b03e64a8236b013
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Wed Aug 25 16:54:57 2021 -0400
Issue 4884 - server crashes when dnaInterval attribute is set to zero
Bug Description:
A division by zero crash occurs if the dnaInterval is set to zero
Fix Description:
Validate the config value of dnaInterval and adjust it to the
default/safe value of "1" if needed.
relates: https://github.com/389ds/389-ds-base/issues/4884
Reviewed by: tbordaz(Thanks!)
commit 16124665cd9ec2b4903520c3dd076e683ea15eb3
Author: Firstyear <william@blackhats.net.au>
Date: Fri Aug 20 09:18:50 2021 +1000
Issue 4877 - RFE - EntryUUID to validate UUIDs on fixup (#4878)
Bug Description: Due to changing the syntax of EntryUUID's
to string, we may have invalid EntryUUID's imported into
the database.
Fix Description: To resolve this during a fixup we validate
that Uuid's have a valid syntax. If they do not, we regenerate
them.
fixes: https://github.com/389ds/389-ds-base/issues/4877
Author: William Brown <william@blackhats.net.au>
Review by: @mreynolds389
commit 66f745864a85b40927de91d2e5ade6d90d97dc45
Author: James Chapman <jachapma@redhat.com>
Date: Sat Apr 24 21:37:54 2021 +0100
Issue 4734 - import of entry with no parent warning (#4735)
Description: Online import of ldif file that contains an entry with
no parent doesnt generate a task warning.
Fixes: https://github.com/389ds/389-ds-base/issues/4734
Author: vashirov@redhat.com (Thanks)
Reviewed by: mreynolds, jchapma
commit a7ca0280f3a54e45a3f3fb7a16681c7d2de7670b
Author: Firstyear <william@blackhats.net.au>
Date: Thu Aug 19 11:06:06 2021 +1000
Issue 4872 - BUG - entryuuid enabled by default causes replication issues (#4876)
Bug Description: Due to older servers missing the syntax
plugin this breaks schema replication and causes cascading
errors.
Fix Description: This changes the syntax to be a case
insensitive string, while leaving the plugins in place
for other usage.
fixes: https://github.com/389ds/389-ds-base/issues/4872
Author: William Brown <william@blackhats.net.au>
Review by: @mreynolds389 @progier389
commit a3d4f63e52737e8ed2cb5b8108cc985697a19c4f
Author: Simon Pichugin <spichugi@redhat.com>
Date: Wed Aug 18 14:51:11 2021 +0200
Issue 4763 - Attribute Uniqueness Plugin uses wrong subtree on ModRDN (#4871)
Bug Description: When using the Attribute uniqueness plugin, restricted
to one subtree, moving an object with an already existing attribute
to this subtree does not raise any exceptions. It appears that the
originating subtree is searched instead.
Fix Description: Use parent DN of the new entry when searching
for attribute uniqueness.
Add test to plugins/attruniq_test.py suite.
Fixes: https://github.com/389ds/389-ds-base/issues/4763
Reviewed by: @tbordaz (Thanks!)
commit 4c5a75ff4f94a06b6104c08abd1f8ee9c2113ee6
Author: Simon Pichugin <spichugi@redhat.com>
Date: Thu Aug 12 09:23:41 2021 +0200
Issue 4851 - Typos in "dsconf pwpolicy set --help" (#4867)
Description: Fix typos in the output of "dsconf instance_name
pwpolicy set --help".
Fixes: https://github.com/389ds/389-ds-base/issues/4851
Reviewed by: @mreynolds389 (Thanks!)
commit 07b44fe5c9a1236a69c2e746287a99fcf4dd2b4d
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Tue Aug 10 11:12:52 2021 -0400
Issue 4736 - lib389 - fix regression in certutil error checking
Description: A regression in the previous commit accidentally called
certutil twice which triggered the CLI to prompt for the NSS database
password. This broke CI tests, etc.
relates: https://github.com/389ds/389-ds-base/issues/4736
Reviewed by: mreynolds (one line commit rule)
commit b99236af65b9459d24e724aa1b6bd32680991da8
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Mon Aug 2 17:04:38 2021 -0400
Issue 4736 - CLI - Errors from certutil are not propagated
Description: Errors from certutil are not returned to the client, and
only a generic failure code is returned. The actual error text should be
returned to the client since it has meaning. Just catch all the
exception and return the output as a ValueError.
relates: https://github.com/389ds/389-ds-base/issues/4736
Reviewed by: firstyear (Thanks!)
commit 4bd1c9408657bed62456dd2e19e2a4832160fb90
Author: Simon Pichugin <spichugi@redhat.com>
Date: Tue Aug 3 14:49:10 2021 +0200
Issue 4460 - Fix isLocal and TLS paths discovery (#4850)
Description: Fix isLocal inconsistency in the 'allocate' code.
Process LDAP URI and decide if it's local or not.
Make sure that while connecting locally the certdir (and other TLS paths) are accessible
(has read right) before setting ldap.OPT_X_TLS_*.
If none ldap.OPT_X_TLS_* options are set and there is no new TLS context,
don't set OPT_X_TLS_NEWCTX. Then /etc/openldap/ldap.conf will be used.
Relates: https://github.com/389ds/389-ds-base/issues/4460
Reviewed by: @mreynolds389, @Firstyear (Thanks!!)
commit 357c16cde5f133e71583461b2f18011e7ac73d98
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Tue Jul 13 14:18:03 2021 -0400
Issue 4443 - Internal unindexed searches in syncrepl/retro changelog
Bug Description:
When a non-system index is added to a backend it is
disabled until the database is initialized or reindexed.
So in the case of the retro changelog the changenumber index
is alway disabled by default since it is never initialized.
This leads to unexpected unindexed searches of the retro
changelog.
Fix Description:
If an index has "nsSystemIndex" set to "true" then enable it
immediately.
relates: https://github.com/389ds/389-ds-base/issues/4443
Reviewed by: spichugi & tbordaz(Thanks!!)
commit c1926dfc6591b55c4d33f9944de4d7ebe077e964
Author: Firstyear <william@blackhats.net.au>
Date: Fri Jul 9 11:53:35 2021 +1000
Issue 4817 - BUG - locked crypt accounts on import may allow all passwords (#4819)
Bug Description: Due to mishanding of short dbpwd hashes, the
crypt_r algorithm was misused and was only comparing salts
in some cases, rather than checking the actual content
of the password.
Fix Description: Stricter checks on dbpwd lengths to ensure
that content passed to crypt_r has at least 2 salt bytes and
1 hash byte, as well as stricter checks on ct_memcmp to ensure
that compared values are the same length, rather than potentially
allowing overruns/short comparisons.
fixes: https://github.com/389ds/389-ds-base/issues/4817
Author: William Brown <william@blackhats.net.au>
Review by: @mreynolds389
commit 5d956fcc782f0b1fefc9748d6509cbf07a6ea853
Author: Thierry Bordaz <tbordaz@redhat.com>
Date: Mon Jul 5 15:59:57 2021 +0200
Issue 4656 - (2nd) Remove problematic language from UI/CLI/lib389
commit fc53c8b228eb8733851a39f081caf44f8987a703
Author: tbordaz <tbordaz@redhat.com>
Date: Fri Jul 2 18:02:54 2021 +0200
Issue 4262 - Fix Index out of bound in fractional test (#4828)
Bug description:
In master branch there are by default 2 groups while
in 1.4.3 it exists only one. So the index '1'
in the retrieved groups raise 'invalid index' exception
in 1.4.3.
Fix description:
Retrieve the specific group bug739172_01group
to test its membership
relates: https://github.com/389ds/389-ds-base/issues/4262
Reviewed by:
Platforms tested: 8.5, fedora
foo
commit 30b1346540ef61ff7047bbdfa102254e1bbf6a09
Author: tbordaz <tbordaz@redhat.com>
Date: Fri Jul 2 13:33:52 2021 +0200
Issue 4822 - Fix CI temporary password: fixture leftover breaks them (#4823)
Bug description:
dirsrvtests/tests/suites/password/pwdPolicy_attribute_test.py contains
password policy attributes tests (min_age,...) and tpr tests.
Leftover of the fixture password_policy (scope module) are breaking
TPR tests with subtree/user local password policy.
Fix description:
Separate temporary password tests into their own module
relates: https://github.com/389ds/389-ds-base/issues/4822
Reviewed by: Simon Pichugin (Thanks!)
Platforms tested: 8.5, F34
commit f17617d168010dca8d6dce787aacd2c9e1778c06
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Thu Mar 11 10:12:46 2021 -0500
Issue 4656 - remove problematic language from ds-replcheck
Description: remove master from ds-replcheck and replace it with supplier
relates: https://github.com/389ds/389-ds-base/issues/4656
Reviewed by: mreynolds
e with '#' will be ignored, and an empty message aborts the commit.
commit 5c88c00d1c29d37f6ddc86c4af793ee7f3888011
Author: Simon Pichugin <spichugi@redhat.com>
Date: Wed Jun 23 10:14:41 2021 +0200
Issue 4803 - Improve DB Locks Monitoring Feature Descriptions
Description: Enchance one line for the threshold setting
as per comment in https://github.com/389ds/389-ds-base/pull/4810
Relates: https://github.com/389ds/389-ds-base/issues/4803
Reviewed by: @droideck (one line rule)
commit 724763b7542cc62232aef5d86bbfde431b6dc140
Author: Simon Pichugin <spichugi@redhat.com>
Date: Wed Jun 23 10:01:30 2021 +0200
Issue 4803 - Improve DB Locks Monitoring Feature Descriptions (#4810)
Description: The description of the field "nsslapd-db-locks-monitoring-threshold"
is unclear. Make the explanations more detailed and concise in both CLI
and Web UI.
Fixes: https://github.com/389ds/389-ds-base/issues/4803
Reviewed by: @tbordaz (Thank you!)
commit 8de81d540b2a5f9ce90a33ac9a20e196090d96d4
Author: tbordaz <tbordaz@redhat.com>
Date: Thu Jun 17 16:22:09 2021 +0200
Issue 4788 - CLI should support Temporary Password Rules attributes (#4793)
Bug description:
Since #4725, password policy support temporary password rules.
CLI (dsconf) does not support this RFE and only direct ldap
operation can configure global/local password policy
Fix description:
Update dsconf to support this new RFE.
To run successfully the testcase it relies on #4788
relates: #4788
Reviewed by: Simon Pichugin (thanks !!)
Platforms tested: F34
commit fa46922b68fed7bd02057c2ff05c79bf172a747c
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Fri Apr 30 10:11:04 2021 -0400
Issue 4506 - Improve SASL logging
Description:
Converted all SLAPI_LOG_TRACE logging to Connection logging (SLAPI_LOG_CONNS).
sasl_errstring() perform a simple and fast switch case mapping from
error code to const string.
relates : https://github.com/389ds/389-ds-base/issues/4506
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed by: mreynolds
commit 1e3f32dc8602828c2f837ea057658547e76f34d1
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Fri Jun 11 16:29:13 2021 -0400
Issue 4093 - Fix MEP test case
Bug Description: Once some compiler warnings were fixed it
accidentally fixed the modrdn behavior. Previously
the modrdn code accidentally ignored errors that the
test case was taking for granted. Once these checks
were properly inforced the teset case started to fail.
Fix Description: Revise test case to "properly" check modrdn operations
by creating the Managed Entry before assignign it to
an entry, and then check for the revise managhed entry
DN after the modrdn takes place.
Also, improved CI debugging logging settings
relates: https://github.com/389ds/389-ds-base/issues/4093
Reviewed by: spichugi(Thanks!)
commit e4612cd47c6bb9a77a7f5e0c5cc97c6d585c49ca
Author: tbordaz <tbordaz@redhat.com>
Date: Wed Jun 16 13:41:27 2021 +0200
Issue 4747 - Remove unstable/unstatus tests (followup) (#4809)
Bug description:
test_syncrepl_basic test is unstable (1 fail out of 10 run)
with a error.PyAsn1Error exception.
Fix description:
flag this tests as flaky
relates: https://github.com/389ds/389-ds-base/issues/4747
Reviewed by: self reviewed (one line commit)
Platforms tested: F33
commit a16a65325e6dfce5afd275600323ec06f9ff83e7
Author: tbordaz <tbordaz@redhat.com>
Date: Mon Jun 7 11:23:35 2021 +0200
Issue 4789 - Temporary password rules are not enforce with local password policy (#4790)
Bug description:
When allocating a password policy structure (new_passwdPolicy)
it is initialized with the local policy definition or
the global one. If it exists a local policy entry, the TPR
attributes (passwordTPRMaxUse, passwordTPRDelayValidFrom and
passwordTPRDelayExpireAt) are not taken into account.
Fix description:
Take into account TPR attributes to initialize the policy
relates: https://github.com/389ds/389-ds-base/issues/4789
Reviewed by: Simon Pichugin, William Brown
Platforms tested: F34
commit 02ca55ddd0c52a51edd302fe5fc4938d2ffd2ea9
Author: tbordaz <tbordaz@redhat.com>
Date: Thu Jun 10 15:03:27 2021 +0200
Issue 4797 - ACL IP ADDRESS evaluation may corrupt c_isreplication_session connection flags (#4799)
Bug description:
The fix for ticket #3764 was broken with a missing break in a
switch. The consequence is that while setting the client IP
address in the pblock (SLAPI_CONN_CLIENTNETADDR_ACLIP), the
connection is erroneously set as replication connection.
This can lead to crash or failure of testcase
test_access_from_certain_network_only_ip.
This bug was quite hidden until the fix for #4764 is
showing it more frequently
Fix description:
Add the missing break
relates: https://github.com/389ds/389-ds-base/issues/4797
Reviewed by: Mark Reynolds
Platforms tested: F33
commit f31010ef70b9f956f96953d559d0a4eaea39d67d
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Mon Jun 7 12:58:42 2021 -0400
Issue 4447 - Crash when the Referential Integrity log is manually edited
Bug Description: If the referint log is manually edited with a string
that is not a DN the server will crash when processing
the log.
Fix Description: Check for NULL pointers when strtoking the file line.
relates: https://github.com/389ds/389-ds-base/issues/4447
Reviewed by: firstyear(Thanks!)
commit bfb3880cf650043cc9b7aefe7c9327937b6edbed
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Fri May 21 14:00:51 2021 -0400
Issue 4773 - Add CI test for DNA interval assignment
Description: Add test case for DNA interval assignment
relates: https://github.com/389ds/389-ds-base/issues/4773
Reviewed by: spichugi(Thanks!)
commit a08540a828dde2f2e1a8d157c38a9be85a5d2876
Author: James Chapman <jachapma@redhat.com>
Date: Tue May 4 15:48:10 2021 +0100
Issue 4750 - Fix compiler warning in retrocl (#4751)
Description: An unused variable generates a compiler warning.
Fix description: Remove unused variable. Modify CI test to restart the test instance instead
of using dynamic plugins.
Fixes: https://github.com/389ds/389-ds-base/issues/4750
Relates: https://github.com/389ds/389-ds-base/issues/4701
Reviewed by: jchapma (One line commit rule)
